Bug 127456 - Add categorized locators to the Finder Framework and WSE
Summary: Add categorized locators to the Finder Framework and WSE
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.5 M6   Edit
Assignee: Chris Brealey CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2006-02-13 09:02 EST by Chris Brealey CLA
Modified: 2006-05-29 20:46 EDT (History)
1 user (show)

See Also:


Attachments
Patch fix to org.eclipse.wst.ws (26.47 KB, patch)
2006-03-20 15:18 EST, Chris Brealey CLA
no flags Details | Diff
Patch fix to org.eclipse.wst.ws.tests (2.23 KB, patch)
2006-03-20 15:18 EST, Chris Brealey CLA
no flags Details | Diff
Patch fix to org.eclipse.wst.ws.explorer (1.81 KB, patch)
2006-03-20 15:18 EST, Chris Brealey CLA
no flags Details | Diff
Patch fix to org.eclipse.jst.ws.axis.consumption.core (10.08 KB, patch)
2006-03-20 15:19 EST, Chris Brealey CLA
no flags Details | Diff
Patch fix to org.eclipse.wst.ws.explorer (6.60 KB, patch)
2006-04-06 11:34 EDT, Chris Brealey CLA
no flags Details | Diff
This fixes the ui in the wse (12.03 KB, patch)
2006-04-07 17:26 EDT, Gilbert Andrews CLA
no flags Details | Diff
complete wse ui change (13.99 KB, patch)
2006-04-10 13:29 EDT, Gilbert Andrews CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Brealey CLA 2006-02-13 09:02:52 EST
The WSE's WSDL browser dialog suffers from a few usability issues:
1. It shows every ".wsdl" file in the workspace, many of which may be old, undeployed, redundant, or just plain incorrect; making the process of locating the correct WSDL document difficult.
2. It provides no way to browse for WSDL documents returned by Web service engines such as by the Axis servlet's "...?WSDL" URL pattern.
3. It provides no categorization of WSDL documents, as in workspace ".wsdl" files vs. deployed Axis WSDL documents vs. WSDL produced by other runtims.

The work to support categorized locators in the Finder Framework that was begun under bug 126529 needs to be completed and exploited from the Web Services Explorer. That is, the WSE's browse dialog should be given a combo box full of known categories (eg. "All", "Uncategorized", "Workspace", "Apache Axis", ...) the current choice of which governs the set of WSDL document file or URIs made available for selection.
Comment 1 Chris Brealey CLA 2006-02-13 09:06:24 EST
An Axis locator and corresponding category should be developed and plugged into the Finder Framework as well.
Comment 2 Chris Brealey CLA 2006-02-13 12:38:38 EST
Apparently the Eclipse package explorer and resource navigator filters out projects that begin with ".". I haven't found an explanation of this yet, but it the WSE WSDL browse dialog's "Project" combo should do likewise. Also, that combo should only appear when workspace locators/categories are used (not when WebSphere or Axis locators/categories are used).
Comment 3 Chris Brealey CLA 2006-03-20 15:18:07 EST
Created attachment 36624 [details]
Patch fix to org.eclipse.wst.ws

First of four patches.
Comment 4 Chris Brealey CLA 2006-03-20 15:18:29 EST
Created attachment 36625 [details]
Patch fix to org.eclipse.wst.ws.tests

Second of four patches.
Comment 5 Chris Brealey CLA 2006-03-20 15:18:45 EST
Created attachment 36626 [details]
Patch fix to org.eclipse.wst.ws.explorer

Third of four patches.
Comment 6 Chris Brealey CLA 2006-03-20 15:19:12 EST
Created attachment 36627 [details]
Patch fix to org.eclipse.jst.ws.axis.consumption.core

Last of four patches.
Comment 7 Chris Brealey CLA 2006-03-20 15:29:31 EST
The first four patches have been committed and consist of:
1. More methods for working with categories.
2. Support for locating Web service clients.
3. An extension with logic for locating Axis Web service clients.

Remaining work:
1. Addition of logic for location Axis Web services.
2. Addition of category selection to the Web Services Explorer browse dialog.

I've also developed a new org.eclipse.jst.ws.axis.consumption.core.tests plugin with a JUnit test to exercise the Axis client locator. I'll commit this later.
Comment 8 Chris Brealey CLA 2006-04-06 11:34:28 EDT
Created attachment 37897 [details]
Patch fix to org.eclipse.wst.ws.explorer

This latest attachment, centered around wsdl_content.jsp, adds a Category control to the WSDL browse dialog. This new control is functional, however, it functions fairly independently from the pre-existing Workspace Project control, and there are a few other simplifications still to be made to the UI:

1. Combine the processing logic for the Category and Workspace Project controls so that a change to either results in repopulation of the WSDL URLs by first finding the appropriate set of Web service client info objects then filtering them by the selected project.

2. Make the appearance of the Workspace Project control conditional on current selection in the Category control. Specifically, the Project control should be visible iff "Workspace WSDL documents" is the current category.

3. Add the special "All" and "Favorites" categories to the Category control. They're special since they do not relate to a specific WebServiceFinder category. The first one should ultimately map to a call against WebServiceFinder.getWebServices(null) instead of to WebServiceFinder.getWebServicesByCategory(...,null). The second one should accomplish the same thing the Workspace/Favourites radio buttons do.

4. Remove the Workspace/Favourites radio buttons.
Comment 9 Chris Brealey CLA 2006-04-06 16:01:53 EDT
Patch 37897 committed and should be released shortly.
Comment 10 Kathy Chan CLA 2006-04-06 18:36:57 EDT
Patch 37897 released to WTP 1.5 as v200604062321.
Comment 11 Gilbert Andrews CLA 2006-04-07 17:26:14 EDT
Created attachment 38049 [details]
This fixes the ui in the wse

I will need to make a further change to incorporate favorites into the all category. This wont be too difficult and should be don shortly.
Comment 12 Gilbert Andrews CLA 2006-04-10 13:29:27 EDT
Created attachment 38177 [details]
complete wse ui change

There are now new categories in a category dropdown  
All
Favorites

extensions...
Apache
Workbench
Comment 13 Kathy Chan CLA 2006-04-11 16:38:34 EDT
Patch 38177 committed.  Will be released later on today to WTP 1.5 M6.
Comment 14 Kathy Chan CLA 2006-04-11 19:29:19 EDT
Released to WTP 1.5 as v200604112312.
Comment 15 Chris Brealey CLA 2006-05-29 20:46:31 EDT
Verified in M6.
Comment 16 Chris Brealey CLA 2006-05-29 20:46:39 EDT
Closed.