Bug 127295 - [clean up] 'Remove unnecessary $NON-NLS$ tags' should remove all if problem set to Ignore
Summary: [clean up] 'Remove unnecessary $NON-NLS$ tags' should remove all if problem s...
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-10 13:28 EST by Markus Keller CLA
Modified: 2006-02-24 05:00 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-02-10 13:28:28 EST 
I20060210-0800

If a project/workspace setting has the $NON-NLS$ problem preference set to 'Ignore', then I would expect that the clean up 'Remove unnecessary $NON-NLS$ tags' removes all $NON-NLS$ tags from the selection.

Use case: I have a project full of $NON-NLS$ tags that were added in the past to avoid warnings. The project does not support i18n, and the tags were only added because there were no project-specific settings when the project started.
Comment 1 Martin Aeschlimann CLA 2006-02-24 05:00:30 EST 
I guess we would need a consistent solution also with the problems generated by JDT.Core. Either '//non-nls' comments are unnecessary when NLS is set to ignore or they aren't.

Moving to jdt.core to make the call.