Bug 127275 - [compiler] Generalize ProblemReporter#localSourceEnd
Summary: [compiler] Generalize ProblemReporter#localSourceEnd
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-10 10:53 EST by Maxime Daniel CLA
Modified: 2006-03-27 15:35 EST (History)
1 user (show)

See Also:

Attachments
Proposed patch and regression tests (4.28 KB, application/octet-stream)
2006-02-21 21:51 EST, Olivier Thomann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2006-02-10 10:53:47 EST 
3.2 M5
Fup on bug 127078.

Philippe suggests that we generalize localSourceEnd in the following manner:
sourceStart(Binding, ASTNode)
sourceEnd(Binding, ASTNode)
with systematic calls.
Comment 1 Philipe Mulet CLA 2006-02-10 11:48:22 EST 
Not for M5, but would be good to have at some point before 3.2 (may need to verify UI assumptions wouldn't be broken).
Comment 2 Olivier Thomann CLA 2006-02-10 21:30:02 EST 
Martin,

I think you said that quickfix could be impacted by that change. Is this still true?
Comment 3 Martin Aeschlimann CLA 2006-02-12 10:57:58 EST 
The quick fix seems to work with the smaller range, so everything ok.
Comment 4 Olivier Thomann CLA 2006-02-21 21:51:31 EST 
Created attachment 35122 [details]
Proposed patch and regression tests
Comment 5 Olivier Thomann CLA 2006-02-24 11:01:07 EST 
Fixed and released in HEAD.
Updated existing regression tests.
Martin, could you please double-check that the released code doesn't break any assumptions for quickfix.
Comment 6 Jerome Lanneluc CLA 2006-03-27 15:35:23 EST 
Verified for 3.2 M6 using build I20060327-0010