Bug 126984 - PDE generating destructive build.xml for plugins that specify Bundle-ClassPath=bin
Summary: PDE generating destructive build.xml for plugins that specify Bundle-ClassPat...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-08 16:14 EST by John Bossom CLA
Modified: 2006-03-10 15:26 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Bossom CLA 2006-02-08 16:14:12 EST
Scenario:
1) Create a dummy plugin
2) Right click on generated MANIFEST.MF and Create Ant File build.xml
3) Verify that the target "@dot" exists in build.xml
4) Add the following line to MANIFEST.MF
   Bundle-ClassPath = bin
5) Re-generate build.xml
6) What should have been "@dot" is now "."

In fact everywhere that the directory "@dot" was referenced is now a ".",
or it is normalized out of existence...

How is this destructive? Don't attempt the "clean" rule as it will delete
your plugin!

i.e.) The first target in the "clean" rule should be
      	<delete dir="${build.result.folder}/@dot"/>

      However, what is generated when 'bin' appears in Bundle-ClassPath
      is:
        <delete dir="${build.result.folder}"/>

As soon as you attempt to perform a clean, your plugin directory will vanish.
(And PDE-Build issues a "clean" prior to building)

While it might not make sense setting 'bin' on the Bundle-ClassPath, it should not cause the generation of the build.xml to be invalid (and dangerous)

Cheers,

John
Comment 1 John Bossom CLA 2006-02-08 17:07:52 EST
oops,

Typo in step 4)

should be
4) Add the following line to MANIFEST.MF
   Bundle-ClassPath: bin

Sorry!

John
Comment 2 John Bossom CLA 2006-02-13 17:24:07 EST
Changed severity from "critical" to "normal" since there is a workaround.
Comment 3 Andrew Niefer CLA 2006-03-10 15:26:35 EST
fixed with patch applied with bug 125432