Community
Participate
Working Groups
I'm opening this bug to make sure we don't lose track of the need to remove org.eclipse.jst.ws.internal.consumption.command.common.CreateModuleCommand. This command has been replaced by org.eclipse.jst.ws.internal.consumption.command.common.CreateFacetedProjectCommand but we have been maintaining CreateModuleCommand to make the transition to facets easier. In the WTP Web services code, CreateModuleCommand is used by org.eclipse.jst.ws.internal.consumption.ui.widgets.test.wssample.AddModuleDependenciesCommand to create an EAR project and Web project for the sample when needed. It is also used by org.eclipse.jst.ws.internal.consumption.ui.widgets.test.CreateSampleProjectCommand but CreateSampleProjectCommand is not used anywhere so this should also be removed.
Since you're creating this command now, I would like to have the ability to set the runtime target based on an existing runtime id. A scenario where this becomes important is if you have multiple servers of the same type. Previously, CreateModuleCommand would end up picking the first runtime type which may not be the desired choice and there was no way to influence this.
Yen, CreatedFacetedProjectCommand (like CreateModuleCommand) is internal and so should not be used by clients/extenders of the WTP platform. As far as I know, there are no plans to make this command API. Regarding the ability to choose a specific server runtime (in addition to a specific server instance and/or server type), I think this is really something that belongs on the IWebService/IWebServiceClient API, the same way we currently have a service instance id and a server type id on WebServiceInfo and WebServiceClientInfo. If you would like this added to the API, please open an enhancement separate from this bug. Thanks. Rupam
Hi Kelvin/Yen, I understand that your extension is still using the CreateModuleCommand, please use the CreateFacetedProjectCommand instead. Please let me know when you have moved off CreateModuleCommand so that we could delete it from WTP. Seng, I'm assigning this over to you since the only places CreateModuleCommand is used is in the org.eclipse.jst.ws.tests.performance and org.eclipse.jst.ws.tests command. Please use the CreateFacetedProjectCommand instead.
Created attachment 92513 [details] jst.ws.tests and jst.ws.tests.performance patch
Thanks for the patch, Seng. It has been committed and released to WTP 3.0 as v200803242129. I'll remove the CreateModuleCommand later on tomorrow.
Patch committed and released to HEAD as v200803261855.
I've checked with all known adoptors and confirmed that they do not use CreateModuleCommand. The command has been removed.
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
Closing on behalf of Rupam.
