Bug 126625 - Added missing options for formatting annotation types
Summary: Added missing options for formatting annotation types
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 126626
  Show dependency tree
 
Reported: 2006-02-06 14:28 EST by Olivier Thomann CLA
Modified: 2006-02-15 07:51 EST (History)
0 users

See Also:


Attachments
Proposed patch (15.04 KB, patch)
2006-02-06 14:29 EST, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2006-02-06 14:28:21 EST
Right now the formatter is sharing the same options to format the annotation type declaration and the type declaration.
We could add the following two options to make the formatting of annotation consistent with enum and type declarations.

FORMATTER_INDENT_BODY_DECLARATIONS_COMPARE_TO_ANNOTATION_DECLARATION_HEADER
FORMATTER_INSERT_NEW_LINE_IN_EMPTY_ANNOTATION_DECLARATION
Comment 1 Olivier Thomann CLA 2006-02-06 14:29:05 EST
Created attachment 34214 [details]
Proposed patch
Comment 2 Olivier Thomann CLA 2006-02-06 14:34:02 EST
The fix is ready to be released if the UI fixes bug 126625.
Comment 3 Olivier Thomann CLA 2006-02-07 10:36:23 EST
Fixed and released in HEAD.
Regression tests in org.eclipse.jdt.core.tests.formatter.FormatterRegressionTests.test612/613
Comment 4 David Audel CLA 2006-02-15 07:51:08 EST
"Verified for 3.2 M5 using build I20060215-0010