Bug 126413 - ShapeColorsAndFontsPropertySection.refresh and ColorsAndFontsPropertySection.refresh leak image handles
Summary: ShapeColorsAndFontsPropertySection.refresh and ColorsAndFontsPropertySection....
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC All
: P1 critical
Target Milestone: 1.0   Edit
Assignee: Tom Macdougall CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 125187 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-02-03 16:00 EST by Harley Nelson CLA
Modified: 2010-07-19 12:26 EDT (History)
3 users (show)

See Also:

Attachments
Disposes Images (13.19 KB, patch)
2006-04-26 15:23 EDT, Nicholas Doyle CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harley Nelson CLA 2006-02-03 16:00:12 EST 
ShapeColorsAndFontsPropertySection.refresh and ColorsAndFontsPropertySection.refresh both create image handles each time they are called.  These images are passed to ToolItems, and the images never get disposed.  This eventually causes an "SWT: No more handles" error, and is probably leaking memory.

In applications that call refresh often, such as applications with active data, this causes loss of functionality in a matter of minutes.  This is a very serious bug for those types of applications.
Comment 1 Steven R. Shaw CLA 2006-02-13 09:37:02 EST 
*** Bug 125187 has been marked as a duplicate of this bug. ***
Comment 2 Steven R. Shaw CLA 2006-04-06 12:46:18 EDT 
can this one get fixed for M6?
Comment 3 Steven R. Shaw CLA 2006-04-18 09:20:29 EDT 
Reassigning to Tom unless Anthony objects...  Tom has a few property page defects to look at...
Comment 4 Nicholas Doyle CLA 2006-04-26 15:23:51 EDT 
Created attachment 39576 [details]
Disposes Images

This patch disposes the Images after they are no longer needed. It also has previous changes regarding removing gradients when the Fonts and Colors Group is drawn.
Comment 5 Anthony Hunter CLA 2006-04-27 16:15:33 EDT 
Committed the patch
Comment 6 Anthony Hunter CLA 2006-04-27 22:11:03 EDT 
Ran sleak and images were still leaking, so delivered an additional fix.
Comment 7 Richard Gronback CLA 2008-08-13 13:04:11 EDT 
[target cleanup] 1.0 RC was the original target milestone for this bug
Comment 8 Eclipse Webmaster CLA 2010-07-19 12:26:51 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug