Bug 126372 - [refactoring] Should make Undo the default when change execution fails
Summary: [refactoring] Should make Undo the default when change execution fails
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard: fix candidate
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-03 12:29 EST by Markus Keller CLA
Modified: 2010-04-20 14:21 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-02-03 12:29:38 EST 
I20060131-1200

Bug 126154 indicates that fatal exceptions can occur during change execution, against which we cannot do anything (e.g. an application like MS Word locked a file the user wanted to rename), and which we cannot detect upfront (because java.io.File does not reveal them).

In such situations we currently show a scary dialog ('scary' is fine;-) with options Undo and Abort, Abort being the default.

I think we should make Undo the default here, since that's what's approriate to try in most cases. Alternatively or additionally, we should put a (partial) undo on  the undo stack if the user choses Abort, such that the undo possibility is not lost.
Comment 1 Markus Keller CLA 2006-02-06 10:52:42 EST 
I'll try to get this in for 3.2.