Bug 126321 - [options] Add constant in JavaCore for nullReference
Summary: [options] Add constant in JavaCore for nullReference
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Maxime Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-03 05:23 EST by Martin Aeschlimann CLA
Modified: 2006-02-14 08:50 EST (History)
0 users

See Also:

Attachments
Add the constant + (3.59 KB, patch)
2006-02-06 06:02 EST, Maxime Daniel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2006-02-03 05:23:03 EST 
20060203

There is no constant for org.eclipse.jdt.core.compiler.problem.nullReference.

There's one for COMPILER_PB_INCONSISTENT_NULL_CHECK = PLUGIN_ID + ".compiler.problem.inconsistentNullCheck"

which doesn't exist in the comment for getDefaultOptions.

Please add the spec at the constant itself, as what we (and probably everybody else) use are the constants, not the strings.
Comment 1 Maxime Daniel CLA 2006-02-06 06:02:29 EST 
Created attachment 34183 [details]
Add the constant +

This patch adds the required constant, plus it deprecates the unused inconsistenNullCheck one, and aligns JavaCore#getDefaultOptions comment with the current default value for nullReference (that is, ignore for now).
Comment 2 Maxime Daniel CLA 2006-02-06 06:04:11 EST 
Verification: visit JavaCore and search for COMPILER_PB_NULL_REFERENCE.
Comment 3 Jerome Lanneluc CLA 2006-02-14 08:50:22 EST 
Verified for 3.2 M5 using build I20060214-0010