Bug 126259 - Error message for incorrect input for Ant task
Summary: Error message for incorrect input for Ant task
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 1.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5 M5   Edit
Assignee: Joan Haggarty CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
: 127938 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-02-02 15:39 EST by Kathy Chan CLA
Modified: 2006-04-20 14:34 EDT (History)
1 user (show)

See Also:


Attachments
apply to community\tutorials\WebServiceAntTask (4.07 KB, patch)
2006-02-21 09:39 EST, Joan Haggarty CLA
no flags Details | Diff
jst.ws.consumption.ui (1.43 KB, patch)
2006-02-22 12:28 EST, Joan Haggarty CLA
no flags Details | Diff
jst.ws.creation.ui (1.43 KB, patch)
2006-02-22 12:29 EST, Joan Haggarty CLA
no flags Details | Diff
wst.command.env (22.13 KB, patch)
2006-02-22 12:29 EST, Joan Haggarty CLA
no flags Details | Diff
jst.ws.consumption.ui (1.11 KB, patch)
2006-02-22 16:14 EST, Joan Haggarty CLA
no flags Details | Diff
jst.ws.creation.ui (1.10 KB, patch)
2006-02-22 16:14 EST, Joan Haggarty CLA
no flags Details | Diff
wst.command.env (21.95 KB, patch)
2006-02-22 16:15 EST, Joan Haggarty CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2006-02-02 15:39:36 EST
Driver:  M0201_0238

I followed the Web services Ant task scenario to create a skeleton Web service.  However, I just changed the 2 required fields for axisservice.properties and did not delete the other properties that was there.  When I ran the Ant task, I got:


Buildfile: D:\wtp\M0201_0238\eclipse\workspace\AntTest\wsgen.xml
        [echo] pulling in property files
        [echo] calling the web services generation ant task: wsgen

main:
       [wsgen] Web Service Runtime IDs (RuntimeId)
       [wsgen] Server runtime: org.eclipse.jst.ws.axis.creation.axisWebServiceRT
       [wsgen] Client runtime: org.eclipse.jst.ws.axis.creation.axisWebServiceRT 
       [wsgen] Server IDs (ServerId)
       [wsgen] Server: org.apache.geronimo.generic.server.10
       [wsgen] Server: org.eclipse.jst.server.generic.weblogic81
       [wsgen] Server: org.eclipse.jst.server.generic.weblogic90
       [wsgen] Server: org.eclipse.jst.server.generic.jboss323
       [wsgen] Server: org.eclipse.jst.server.generic.jboss4
       [wsgen] Server: org.eclipse.jst.server.generic.jonas4
       [wsgen] Server: org.eclipse.jst.server.generic.oracle1013
       [wsgen] Server: org.eclipse.jst.server.tomcat.32
       [wsgen] Server: org.eclipse.jst.server.tomcat.40
       [wsgen] Server: org.eclipse.jst.server.tomcat.41
       [wsgen] Server: org.eclipse.jst.server.tomcat.50
       [wsgen] Server: org.eclipse.jst.server.tomcat.55
       [wsgen] Server: org.eclipse.jst.servers.websphere.6
       [wsgen] Executable extension definition for "transform" not found.
       [wsgen] IWAB0014E Unexpected exception occured.
BUILD SUCCESSFUL
Total time: 141 milliseconds

Once I delete the unused properties and only have the 2 required fields, the Ant task completed fine.
Comment 1 Joan Haggarty CLA 2006-02-15 08:43:47 EST
*** Bug 127938 has been marked as a duplicate of this bug. ***
Comment 2 Joan Haggarty CLA 2006-02-17 11:40:08 EST
Include in this fix - properties with empty strings as settings, required properties that are completely missing such as scenarioType and InitialSelection.
Comment 3 Kathy Chan CLA 2006-02-20 15:34:00 EST
Joan.  Please update the Ant tutorial to instruct the user to delete the entries that would cause problem.
Comment 4 Peter Moogk CLA 2006-02-20 15:41:08 EST
Hi Joan,
   It doesn't think the user should have to remove property values from the properties files in order to make the ant script work.  It is handy to have the the property lines in the file, since it gives the user an idea of what properties are available and what the syntax is.  However, I would suggest that these lines should be commented out initially so that the user doesn't have to delete them to get the script to work.
Comment 5 Joan Haggarty CLA 2006-02-20 15:47:02 EST
Yes, Peter - I'd agree with you that non-required properties in the file are better commented out.  The user can add in properties they require as the need arises.  Better for the default to be the basic settings and the user can add in the advanced ones.  Thanks for your input.
Comment 6 Joan Haggarty CLA 2006-02-20 15:48:02 EST
Kathy - do you want the tutorial modified until changes are made that make removing the properties necessary?  Then we would change it back to how it is now?
Comment 7 Joan Haggarty CLA 2006-02-21 09:39:24 EST
Created attachment 35070 [details]
apply to community\tutorials\WebServiceAntTask

Removed "no Linux" comment from intro.  Also added more explicit notes to both the service and client scenarios to remove additional properties from the properties file before running the Ant task.
Comment 8 Joan Haggarty CLA 2006-02-22 12:24:49 EST
Summary of changes for this bug fix - patches will be attached shortly:

1. Addressed missing required properties (i.e. scenarioType and InitialSelection deleted or commented out).
Added an optional attribute on the Ant mapping extension point called "required".  
This attribute can be set to say that a property must be set in the Ant property file.  The AntEnvironment checks to see that all 
required properties are set in the  property file and if not, prints a message to the user.

2. Properties with empty strings as values are now detected in the AntEnvironment.  These are treated as if the property was not set at all.  In addition if a 
Verbose property is set to true in the property file, informational messages will be provided to the user to say which 
non-required properties were not explicitly set and will be defaulted.

3. Commented out all properties in the sample property files except for required properties, utility properties, web service runtime and server. The remaining
properties are provided to show what properties are available and to provide sample values and documentation for the user of the Ant tasks.
Extenders should do the same in their sample property files for properties with sample values.

4. Capitalized scenarioType to match other properties which are all capitalized.  The property is now ScenarioType.  
Extenders of the Ant tasks will need to modify their property files accordingly.
Comment 9 Joan Haggarty CLA 2006-02-22 12:28:23 EST
Created attachment 35157 [details]
jst.ws.consumption.ui

patch 1 of 3
Comment 10 Joan Haggarty CLA 2006-02-22 12:29:00 EST
Created attachment 35158 [details]
jst.ws.creation.ui

patch 2 of 3
Comment 11 Joan Haggarty CLA 2006-02-22 12:29:23 EST
Created attachment 35159 [details]
wst.command.env

patch 3 of 3
Comment 12 Joan Haggarty CLA 2006-02-22 12:30:34 EST
Ready to be reviewed/committed.

Kelvin - this is the bug containing the discussed change to the scenarioType property.  You need to change your property files so that the property is now ScenarioType.  This is for the 1.5 timeframe.

thanks, Joan.
Comment 13 Joan Haggarty CLA 2006-02-22 16:14:07 EST
Created attachment 35193 [details]
jst.ws.consumption.ui

replacement patch 1 of 3 - keep plugin.xml scenarioType attribute lowercase.  Proprety will still be capitalized as ScenarioType.
Comment 14 Joan Haggarty CLA 2006-02-22 16:14:30 EST
Created attachment 35194 [details]
jst.ws.creation.ui

replacement patch 2 of 3 - keep plugin.xml scenarioType attribute lowercase.  Proprety will still be capitalized as ScenarioType.
Comment 15 Joan Haggarty CLA 2006-02-22 16:15:43 EST
Created attachment 35195 [details]
wst.command.env

replacement patch 3 of 3 - keep plugin.xml scenarioType attribute lowercase.  Proprety will still be capitalized as ScenarioType.  This patch adds code to AntEnvironment so that the property and extension attribute are independent.
Comment 16 Chris Brealey CLA 2006-02-22 17:28:25 EST
Reviewed, committed and released, tag v200602221030. Thanks Joan.
Comment 17 Chris Brealey CLA 2006-02-23 14:02:06 EST
Committed into M5.
Comment 18 Kathy Chan CLA 2006-04-04 17:52:59 EDT
Verified on V200604040834.