Bug 12618 - Computation of Adornment Flags is slow
Summary: Computation of Adornment Flags is slow
Status: RESOLVED DUPLICATE of bug 11164
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Erich Gamma CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2002-04-02 10:33 EST by Tod Creasey CLA
Modified: 2002-12-10 13:23 EST (History)
1 user (show)

See Also:

Attachments
computeAdornmentFlags (20.85 KB, text/plain)
2002-12-03 04:33 EST, Adam Kiezun CLA 		no flags Details
computeAdornmentFlags2 (32.70 KB, text/plain)
2002-12-03 04:44 EST, Adam Kiezun CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2002-04-02 10:33:19 EST 
The computation of the adornment flags for the PackagesView can take as long as 
1300 ms if you create a workbench with all of Eclipse loaded with source and 
then switch to the Java Perspective.

The method ErrorTickAdornementProvider.computeAdornmentFlags is the one this 
timing was taken for with OptimizeIt.
Comment 1 Erich Gamma CLA 2002-04-04 14:10:54 EST 
How many errors did the workspace have?
Could please attache the optimize it trace. It is easy to export a trace as 
html. Seeing the number 1300ms is not very helpfull.
Comment 2 Tod Creasey CLA 2002-04-04 14:27:54 EST 
There were approximately 11,000 errors in this case. I will run it again and 
get a stack trace.
Comment 3 Adam Kiezun CLA 2002-12-02 09:15:25 EST 
Todd, do you think it is still a problem or can we close this one?
Comment 4 Adam Kiezun CLA 2002-12-02 09:15:49 EST 
sorry for misspelling your name, Tod
Comment 5 Tod Creasey CLA 2002-12-02 09:24:10 EST 
I will need to bench again to be sure. And no problem about mispelling the 
name - it is a wierd one if you live in a German speakingcountry anyways 
<grin>...
Comment 6 Adam Kiezun CLA 2002-12-03 04:33:44 EST 
Created attachment 2615 [details]
computeAdornmentFlags
Comment 7 Adam Kiezun CLA 2002-12-03 04:34:27 EST 
computeAdornmentFlags takes 1% of startup time (52 error-markers in workspace)
Comment 8 Adam Kiezun CLA 2002-12-03 04:44:32 EST 
Created attachment 2616 [details]
computeAdornmentFlags2

nope, it's more because it's called via multiple paths -
find 'computeAdornmentFlags' in the trace attached
Comment 9 Adam Kiezun CLA 2002-12-04 05:28:14 EST 
it's slow because collecting markers is slow. see bug 11164
Comment 10 Adam Kiezun CLA 2002-12-04 06:05:03 EST 
on a big  workpace (820 markers) computeAdornmentFlags takes 13-14 %
all of which is spent in collecting markers.
considering making this bug depend on bug 11164.
Comment 11 Adam Kiezun CLA 2002-12-10 13:23:11 EST 
this is a dup of bug bug 11164 really

*** This bug has been marked as a duplicate of 11164 ***