Bug 125673 - [evaluation] Improve error message for method invocation on manually suspended threads
Summary: [evaluation] Improve error message for method invocation on manually suspende...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 137066 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-30 03:18 EST by Dani Megert CLA
Modified: 2007-07-31 15:57 EDT (History)
2 users (show)

See Also:

Attachments
Picture showing problem (24.00 KB, image/png)
2006-01-30 03:19 EST, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-01-30 03:18:54 EST 
I20060125-0800

I've suspended the main thread and wanted to look at an instance of Display in the Variables view. However, the display area simply says that I first have to suspend the thread (see attached picture.

I have no detail formatter for 'Display'.
Comment 1 Dani Megert CLA 2006-01-30 03:19:31 EST 
Created attachment 33774 [details]
Picture showing problem
Comment 2 Dani Megert CLA 2006-01-30 03:24:56 EST 
OK, I guess I didn't fully digest the info text in the display area. What it really wanted to say is: "You manually suspended the thread and hence the details can't be displayed.". Correct? If so, OK to close.
Comment 3 Darin Wright CLA 2006-01-30 08:56:57 EST 
Correct, this is a VM limitation.
Comment 4 Dani Megert CLA 2006-01-30 09:02:05 EST 
Could the message be improved?
Comment 5 Darin Wright CLA 2006-01-30 11:45:01 EST 
Probably. The evaluatuion engine has no idea why it was invoked (to peform toString, etc), so the "detail" manage will likely have to intercept and replace the error message with something else.
Comment 6 Darin Wright CLA 2006-03-14 14:37:02 EST 
Deferred
Comment 7 Darin Wright CLA 2006-04-17 16:05:55 EDT 
*** Bug 137066 has been marked as a duplicate of this bug. ***
Comment 8 Darin Wright CLA 2006-06-14 14:14:28 EDT 
Re-open to mark dup
Comment 9 Darin Wright CLA 2006-06-14 14:15:16 EDT 
and press the 'reopen' button
Comment 10 Darin Wright CLA 2006-06-14 14:16:06 EDT 

*** This bug has been marked as a duplicate of 34440 ***
Comment 11 Darin Wright CLA 2007-06-19 10:29:49 EDT 
Re-opening to improve message in var view and debug popups when no thread is available for computing toString().
Comment 12 Curtis Windatt CLA 2007-06-19 12:20:35 EDT 
Any suggestions on a better error message?

It is straight forward to change it when computing details as we can check for a specific error code when computing java details.
Comment 13 Dani Megert CLA 2007-06-20 03:12:16 EDT 
Something along comment 2?
Comment 14 Darin Wright CLA 2007-06-20 10:40:47 EDT 
Perhaps "<details unavailable in manually suspended thread>".
Comment 15 Dani Megert CLA 2007-06-20 10:43:36 EDT 
I would use pro-active voice i.e. The/This thread has been manually suspended and hence there are no details available.
Comment 16 Curtis Windatt CLA 2007-07-18 16:55:30 EDT 
Latest suggestion:
"This thread has been manually suspended. Object details are unavailable."
Opinions?

Discovered a bug while playing around with this.  When manually suspended, array value details give a detail formatter error (even though they have no detail formatter).  Filing a separate bug report.

Darin has suggested that it would be good if we could find a better way of presenting detail errors to the user.  Currently we simply display them as text in the source viewer (which is editable).  One possible idea would be to allow the detail listener to return an IStatus, and create an image and label to display the message.  This will likely end up being a separate enhancement request.
Comment 17 Dani Megert CLA 2007-07-23 05:06:01 EDT 
I would say why the object details are unvailable. This isn't 100% clear from your suggestion.
==>
This thread has been manually suspended and therefore object details are unavailable.
Comment 18 Curtis Windatt CLA 2007-07-24 11:32:50 EDT 
Alright, we'll use "This thread has been manually suspended and therefore object details are unavailable."

Fixed in HEAD, see JavaDetailFormattersManager.java, DebugUIMessages.java and DebugUIMessages.properties.
Comment 19 Curtis Windatt CLA 2007-07-31 10:48:28 EDT 
Mike, please verify.
Comment 20 Michael Rennie CLA 2007-07-31 15:57:40 EDT 
verified that the nomenclature of the error statement is satisfactory.