Community
Participate
Working Groups
There are many instances in PDE (well, not just PDE) where there is no context help available - it is either just not there or we get the default parent help like for the new or import/export wizards. This will become more apparent once the help button is added to dialogs. Here are some examples as I was going through.. but this list is not complete: Preferences: Target platform page: Target Profiles section (bottom): Profile link -> resulting dialog Browse... -> resulting dialog Launching Arguments tab: Variables...: resulting dialog Edit Variables... -> New... -> resulting dialog Configure... -> resulting dialog Implicit Dependencies tab: Add... -> resulting dialog Views: Error Log: Right click -> Event Details -> resulting dialog View menu -> Filters... -> resulting dialog Plug-in Dependencies: Right click -> Focus On... -> resulting dialog Editors: plugin.xml editor: Overview tab: Browse... -> resulting dialog Add.. -> resulting dialog Dependencies tab: both Add.. buttons -> resulting dialog both Properties... buttons -> resulting dialog Runtime tab: all Add... buttons -> resulting dialog Properties... -> resulting dialog New... -> resulting dialog Extension points tab: Browse... -> resulting dialog Wizards: New: Extension Point Schema: Extensino Point Schema Properties (first page) -> Browse... -> resulting dialog (both buttons) Feature Patch: Patch Properties (page 2) -> Browse... -> resulting dialog Fragment Project: Fragment Content (page 2) -> Browse... -> resulting dialog Plug-in from existing JAR file: Add.. -> resulting dialog Product Configuration: wizard page Target Profile: wizard page Export: Eclipse product: main wizard page Browse... -> resulting dialog
joy :(
I will provide a patch for RC1.
Are you planning to provide a patch or is this too much Ben :)?
bumping to RC3 for doc pass
Created attachment 101390 [details] Patch Oops, sorry for being a bit late... RC3 seems more reasonable indeed. The patch has outgoing modifications for o.e.pde.doc.user, o.e.pde.ui, and o.e.ui.views.log.
(In reply to comment #0) Every problem explicited in the original comment should have been addressed. See below. However, there are probably some other places where context help is not available. We probably need to do a more exhaustive search among every dialogs, wizards and preference pages... Joy once again :( ! Preferences: Target platform page: Target Profiles section (bottom): Profile link -> resulting dialog ALREADY FIXED Browse... -> resulting dialog FIXED Launching Arguments tab: Variables...: resulting dialog ALREADY FIXED but the help is talking about "launching platforms" (because it comes from Platform/Debug). Edit Variables... -> New... -> resulting dialog --> bug against Platform/Debug Configure... -> resulting dialog -> This is a Platform/DEBUG bug Implicit Dependencies tab: Add... -> resulting dialog FIXED Views: Error Log: Right click -> Event Details -> resulting dialog FIXED View menu -> Filters... -> resulting dialog FIXED Plug-in Dependencies: Right click -> Focus On... -> resulting dialog FIXED Editors: plugin.xml editor: Overview tab: Browse... -> resulting dialog ALREADY FIXED Add.. -> resulting dialog FIXED Dependencies tab: both Add.. buttons -> resulting dialog HELP HAS BEEN DISABLED both Properties... buttons -> resulting dialog FIXED Runtime tab: all Add... buttons -> resulting dialog FIXED Properties... -> resulting dialog FIXED New... -> resulting dialog FIXED Add... -> resulting dialog (not initially mentioned by Curtis) FIXED Extension points tab: Browse... -> resulting dialog FIXED Wizards: New: Extension Point Schema: Extensino Point Schema Properties (first page) -> Browse... -> resulting dialog (both buttons) FIXED Feature Patch: Patch Properties (page 2) -> Browse... -> resulting dialog FIXED Fragment Project: Fragment Content (page 2) -> Browse... -> resulting dialog FIXED (???) Plug-in from existing JAR file: Add.. -> resulting dialog FIXED Product Configuration: wizard page ALREADY FIXED, see bug 139104 Target Profile: wizard page ALREADY FIXED, see bug 139104 Export: Eclipse product: main wizard page ALREADY FIXED, see bug 139104 Browse... -> resulting dialog FIXED
wow, greatest patch ever Thanks Ben.
+1, please review Curtis, we can get this in on RC3
There are some extra changes to PluginContentPage.java that cause errors. We'll also have to try to add help topic links. But overall an awesome contribution to PDE help. Thanks! +1 for RC3.
Ouch, PluginContentPage shouldn't have been included in the patch, sorry! :/ If you commit my patch early enough in RC3 (without PluginContentPage..!), I'll try to verify once again every item listed in the initial comment has been addressed, and I'll probably find some other places where context help need to be added!
Created attachment 101596 [details] Updated patch (PluginContentPage.java invalid modifications removed)
(In reply to comment #10) > Ouch, PluginContentPage shouldn't have been included in the patch, sorry! :/ > If you commit my patch early enough in RC3 (without PluginContentPage..!), I'll > try to verify once again every item listed in the initial comment has been > addressed, and I'll probably find some other places where context help need to > be added! > Well, with an offer like that we have no choice but to get it in at the start of RC3. In fact, I'm seriously considering putting it in right now :)
Applied the updated patch to HEAD. Thanks again.
This will make it into RC2 when I tag tonight.
Thanks Ben and Curtis!
