Bug 125126 - Accessibility required for Web Services
Summary: Accessibility required for Web Services
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5 M5   Edit
Assignee: andy zhai CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2006-01-25 02:39 EST by Masayuki Fuse CLA
Modified: 2006-04-20 14:33 EDT (History)
5 users (show)

See Also:


Attachments
patch fix to 125126 org.eclipse.jst.ws.consumption.ui (3.61 KB, text/plain)
2006-02-08 16:09 EST, andy zhai CLA
no flags Details
patch fix to 125126 org.eclipse.jst.ws.creation.ui (1.05 KB, patch)
2006-02-08 16:10 EST, andy zhai CLA
no flags Details | Diff
patch fix to 125126 org.eclipse.jst.ws.ui (1.84 KB, patch)
2006-02-08 16:10 EST, andy zhai CLA
no flags Details | Diff
patch fix to 125126 org.eclipse.wst.ws.ui (1.65 KB, patch)
2006-02-08 16:11 EST, andy zhai CLA
no flags Details | Diff
snapshot of preference page: popup Dialog Selection (892.14 KB, image/bmp)
2006-02-08 16:13 EST, andy zhai CLA
no flags Details
snapshot of preference page: Profile Comliance And Validation (961.87 KB, image/bmp)
2006-02-08 16:14 EST, andy zhai CLA
no flags Details
preference page: projectTopology (961.87 KB, patch)
2006-02-08 16:15 EST, andy zhai CLA
no flags Details | Diff
preference page: resource Management. (961.87 KB, image/bmp)
2006-02-08 16:16 EST, andy zhai CLA
no flags Details
prefefence page: scenario Defaults (992.63 KB, image/bmp)
2006-02-08 16:17 EST, andy zhai CLA
no flags Details
patch fix to 125126 (4.56 KB, application/x-zip-compressed)
2006-02-09 11:44 EST, andy zhai CLA
no flags Details
pictures of web service preference pages (617.18 KB, application/x-zip-compressed)
2006-02-09 11:46 EST, andy zhai CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masayuki Fuse CLA 2006-01-25 02:39:34 EST
In 1.5 M4, preferences pages of Web Services don't have accelerator key.
Comment 1 Chris Brealey CLA 2006-01-25 09:09:31 EST
Fuse-san,
I need more information to understand the problem better. Keyboard navigation thru the preference wizard using tabs, letter keys and so forth is working for me. I have not found any accelerator keys for any of the preference pages, and I haven't found in the Eclipse docs how to bind accelerators to specific preference pages. Would you please explain in detail the scenario that should work (but doesn't), and also point me to an example of a preference page in Eclipse for which accelerators do work?

Thanks - CB.
Comment 2 Masayuki Fuse CLA 2006-01-25 22:25:36 EST
Please take a look at Accessibility section on Eclipse UI guideline at http://www.eclipse.org/articles/Article-UI-Guidelines/Index.html

For an example, please install example of Eclipse platform SDK, that has readme example at org.eclipse.ui.examples.readmetool. Please look at message.properties file and Preferences > Readme Example. You just need add & to a character of label for the accelerator key. That is common way to add accelertor key. Thanks.

Comment 3 Chris Brealey CLA 2006-02-08 10:54:56 EST
Andy, would you please handle this one? Thanks - CB.
Comment 4 andy zhai CLA 2006-02-08 16:09:32 EST
Created attachment 34378 [details]
patch fix to 125126 org.eclipse.jst.ws.consumption.ui
Comment 5 andy zhai CLA 2006-02-08 16:10:09 EST
Created attachment 34379 [details]
patch fix to 125126 org.eclipse.jst.ws.creation.ui
Comment 6 andy zhai CLA 2006-02-08 16:10:55 EST
Created attachment 34380 [details]
patch fix to 125126 org.eclipse.jst.ws.ui
Comment 7 andy zhai CLA 2006-02-08 16:11:31 EST
Created attachment 34381 [details]
patch fix to 125126 org.eclipse.wst.ws.ui
Comment 8 andy zhai CLA 2006-02-08 16:13:47 EST
Created attachment 34382 [details]
snapshot of preference page: popup Dialog Selection
Comment 9 andy zhai CLA 2006-02-08 16:14:33 EST
Created attachment 34383 [details]
snapshot of preference page: Profile Comliance And Validation
Comment 10 andy zhai CLA 2006-02-08 16:15:46 EST
Created attachment 34384 [details]
preference page: projectTopology
Comment 11 andy zhai CLA 2006-02-08 16:16:31 EST
Created attachment 34385 [details]
preference page: resource Management.
Comment 12 andy zhai CLA 2006-02-08 16:17:09 EST
Created attachment 34386 [details]
prefefence page: scenario Defaults
Comment 13 andy zhai CLA 2006-02-08 16:25:51 EST
Hi Chris,
I have added the accelerator key for all labels of preferences pages  of Web service.
and I uploaded 5 pictures for updated preference pages.
you can see what I have chosen for accelerator key.
(the accelerator key is character with a "_" beneath it.)
If I need to choose better accelerator keys for each preference page, please let me know.  
Comment 14 Chris Brealey CLA 2006-02-08 23:21:44 EST
Andy,
thanks for the fix - Nicely done. Some of the controls on the pages don't have accelerators. Maybe they don't make sense for controls like combo boxes and entry fields, but there are a few push buttons (eg. "Move up", "Move down", "Show all", "Hide all") that might benefit.

Fuse-san,
it seems most, if not all, the Eclipse platform's preference pages have no accelerators for their control labels. Why is that?
Comment 15 Masayuki Fuse CLA 2006-02-09 01:15:02 EST
I think that combo box should have short cut key as well. Eclipse platform's preferences page has it for combo box.

Pat, any comment?
Comment 16 andy zhai CLA 2006-02-09 11:44:33 EST
Created attachment 34427 [details]
patch fix to 125126 

patch fix to 125126 including modification of 5 plugins
Comment 17 andy zhai CLA 2006-02-09 11:46:13 EST
Created attachment 34428 [details]
pictures of web service preference pages
Comment 18 andy zhai CLA 2006-02-09 11:55:11 EST
Chris,

I have added the accelerators for combox and push buttons.
I attached 2 zip files including all patches to 5 plugins and snapshots.

I failed to add accelerators for 2 entry fields (by only adding '&').
1. Project Topology -> Client type:
2. Test Facility Defaults -> Java proxy sample
If accelerators are needed for these 2 items. The code to create the labels may have to be changed.
Comment 19 Steven Wasleski CLA 2006-02-13 11:31:49 EST
With regard to comment 14, it sounded strange to me that the platform preferences would be missing accelerators so I took a quick look at the latest N build and I did not see them either.... until I started using the keyboard to navigate around the pages, then they all appeared.

Fuse-san, do you have another bug open already covering this behavior?
Comment 20 Masayuki Fuse CLA 2006-02-14 03:02:59 EST
Steve,
I've not seen on Eclipse Platform.
Comment 21 Chris Brealey CLA 2006-02-22 10:45:15 EST
Thanks. Reviewed and committed. To be released shortly.
Comment 22 Kathy Chan CLA 2006-02-22 14:48:58 EST
Released to HEAD as v200602221946.
Comment 23 Masayuki Fuse CLA 2006-04-11 00:57:01 EDT
Verified in 200603302119. Closing, Thanks.