Community
Participate
Working Groups
See http://www.eclipse.org/newsportal/article.php?id=759&group=eclipse.technology.gmf#759 and http://www.eclipse.org/newsportal/article.php?id=804&group=eclipse.technology.gmf#804 for initial reqs.
Created attachment 48315 [details] Fixes the subj Proposed patch contents: GMFMap model: ChildReference#affixedSide attribute introduced. Allowed values: NONE (default, for backward compatibility), ANY (most common behavior), SOUTH, NORTH, WEST, EAST (that is, multiple preferred sides like (SOUTH or WEST) are not supported). This attribute is directly editable from GMFMap editor. GMFMap model: Also new constraints added to prevent pure labels and compartment-ed children to be side-affixed. GMFGen model: GenChildSideAffixedNode extends GenChildNode class introduced. It does not has any editable attributes and used only as a marker that side-affixed edit parts should be generated. Templates: NodeEditPart.javajet checks combination of the isSideAffixed() / hasSideAffixedChildren() properties and uses appropriate runtime superclass for generated editparts. Some other adjustments introduced into template to make the code compilable. In case if node is nether bordered nor border item, generated code is the same as before. New enum attribute affixedSide intri Fixes the subj using common runtime infrastructure for bordered/border editparts, that is BorderedBorderItemEditPart, AbstractBorderItemEditPart and AbstractBorderedShapeEditPart)
Created attachment 48316 [details] Icons for new gmfgen classes (zipped)
Created attachment 48395 [details] Fixes the subj even better Slightly enchanced version of the patch that fixes the subj. Changes: 1. int GMFGen.GenChildSideAfficedNode#preferredSide -> String GMFGen.GenChildSideAfficedNode#preferredSideName to replave magic numbers with constants from d2d.PositionConstants 2. NodeEditPart.javajet now takes into account the preferred side of the parent 3. Validation OCL for gmfmap corrected
affixedSide is not gmfmap's attribute, it has nothing to do with mapping domain elements to visual, rather is an attribute of the diagram node.
Created attachment 48612 [details] Fixes the subj even more better User-editable values are now in gmfgraph model (Node#affixedParentSide : Direction) + Added basic reconcilation for Viewmap attributes for border nodes
Added contributed keyword for IP log automation. Patch appears to have been committed by atikhomirov, according to CVS log.
I have just got notification about new CC added and would like to clarify. AFAIK, this patch was comitted into the 2.0 stream, and border items are supported now in the gmfgraph model. The only reason for this item to be still opened is the lack of unit tests. Certainly, before commit it was carefully checked with manual testing. Artem, could you please confirm this? Regards, Michael
(In reply to comment #7) Yes, the reason this bugzilla is still open is that someone promised to write few tests to cover this functionality ;)
[GMF Restructure] Bug 319140 : product GMF and component Models was the original product and component for this bug
