Community
Participate
Working Groups
I20060117 I updated (using update manager) my eclipse intall to a more recent build. On disk I now have multiple copies (with different versions) of the same feature. Now when I'm creating a feature and try to add an included feature, the feature selection dialog shows features that are disabled from an update point of view.
Created attachment 67929 [details] org.eclipse.pde.core.patch
Ok, here is a patch. First, when we were looking for configured site paths, we were scanning the base directory with no regard to the status of feature or plug-in. Next, when we were building the locations of configured site paths, we had an un-necessary if clause, instead we should be resolving the urls using FileLocator to get an absolute location. In the end, this patch simply grabs all the configured features (which is what is listed in the platform.xml)
hold off on reviewing patch, it doesn't work in cases when your target platform isn't the same as your host.
Created attachment 68273 [details] org.eclipse.update.configurator.patch try this patch out for now Wassim and tell me the results. I'm sleepy tonight.
Chris, I presume you want me to try the pde.core patch AND the update.configurator patch. I tried the host != target test case. I am now getting the right list of plug-ins. Unfortunately, they are all prefixed with the wrong path. ie. I am getting the list of target bundles but they have the host's path as a prefix.
Created attachment 68346 [details] uber.patch Here is an updated patch, I don't think I gave you the latest patch, I'm not seeing this problem.
Patch works very well. This patch also resolves the plug-in side of it (bug 175076), which is the more pressing issue than the features. One suggestion: PluginPathFinder#getConfiguredSitePaths(..) should merge with PluginPathFinder#getExtensionPluginURLs(..) though. The latter also has an unfortunate name since it is also used to retrieve features. Chris, can you open a bug about the Update issue and attach the patch?
+1. Should we release the PDE portion of the patch before releasing the Update portion? Just want to make sure we don't break anything with half a patch.
Our half won't work without the Update half.
Created attachment 69831 [details] org.eclipse.pde.core.patch updated patch
Adding Dejan as second component needed to approve this fix for RC4.
moving back to the inbox this may not be as important when p2 comes alive in 3.4
Chris, with the fix from 141887, should we include this patch now?
With the introduction of p2, this bug is not worth pursuing. Closing as INVALID.
