Bug 123784 - Cannot connect LED inside circuit to LED outside circuit
Summary: Cannot connect LED inside circuit to LED outside circuit
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P3 normal
Target Milestone: ---   Edit
Assignee: Steven R. Shaw CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
: 130021 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-13 11:37 EST by Cherie Revells CLA
Modified: 2006-03-06 16:33 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2006-01-13 11:37:03 EST 
1. Create a logic diagram
2. Create a Circuit shape and an LED shape on the diagram.
3. Create 2 LED shapes inside the Circuit shape.
4. Connect 1 LED inside Circuit to LED outside Circuit shape.
RESULT:  The cursor shows that this gesture is possible, but after clicking on the target terminal the wire does not appear.  No error messages either.
Comment 1 Steven R. Shaw CLA 2006-03-06 10:58:06 EST 
Since that machine is "toast" do we have to jump through any administrative hoops to get an IBM machine that works?
Comment 2 Steven R. Shaw CLA 2006-03-06 11:07:31 EST 
ignore last comment
Comment 3 Steven R. Shaw CLA 2006-03-06 11:13:34 EST 
Trivial change in example code to include wire that start or end outside of the circuit container.
Comment 4 Steven R. Shaw CLA 2006-03-06 11:24:15 EST 
*** Bug 130021 has been marked as a duplicate of this bug. ***
Comment 5 Steven R. Shaw CLA 2006-03-06 13:31:20 EST 
Reverted change due to test failures... change should valid though?  Reopened to investigate further.
Comment 6 Steven R. Shaw CLA 2006-03-06 16:33:20 EST 
Fixed again to check if one end was contained in the circuit but not one of the terminal ends on the circuit -->

{
< existing criteria >
}
else {
  if ((!wire.getSource().eContainer().equals(circuitElement) && 
      EcoreUtil.isAncestor(circuitElement, wire.getSource().eContainer())) ||
      (!wire.getTarget().eContainer().equals(circuitElement) &&
      EcoreUtil.isAncestor(circuitElement, wire.getTarget().eContainer()))) {
      wires.add(wire);
   }
}
Comment 7 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug