Bug 123029 - "Quick fix" of "Enclose body in braces" fails to "fix all problems of this kind"
Summary: "Quick fix" of "Enclose body in braces" fails to "fix all problems of this k...
Status: CLOSED INVALID
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2006-01-08 07:52 EST by fx CLA
Modified: 2009-08-30 02:06 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fx CLA 2006-01-08 07:52:10 EST 
When using quick for the following code:

if(aa==bb)
    System.out.println("test");

After I select "Enclose body in braces", A dialog show.
I checked the "Fix all problems of this kind". But only THIS problem of this kind is fixed, not     
 ALL.
Comment 1 Martin Aeschlimann CLA 2006-01-09 03:27:16 EST 
Please give reproducable steps. How did you get a dialog? Are you using additional plugins offering this option?

What I understood:
  - In the Java editor, plave the cursor at the if statement, Press Ctrl + 1
  - Select 'Change if statement to block'
  - Changes applied, no dialog
Comment 2 Martin Aeschlimann CLA 2006-01-10 10:50:20 EST 
setting to remind. Please reopen if you have more information
Comment 3 fx CLA 2006-01-11 07:43:09 EST 
Hi Martin Aeschlimann,

When using quick for the following code:

if(aa==bb)//$$$
    System.out.println("test");//###

I place cursor at "###", NOT at "$$$".
When I place cursor at "$$$", and press Ctrl+1, NO dialog show.
But I place cursor ar "###", and press Ctrl+1, dialog shows.
After I select "Enclose body in braces", A dialog show.
I checked the "Fix all problems of this kind". But only THIS problem of this
kind is fixed, not ALL.
Comment 4 fx CLA 2006-01-11 08:20:15 EST 
Hi Martin Aeschlimann,

I updated my Eclipse from 3.1 to 3.1.1.
I found, In 3.1.1 no dialog will appear. Maybe the dialog is produced by a plugin, but I can not find out which plugin produced the dialog.
Comment 5 Benno Baumgartner CLA 2006-01-11 08:34:00 EST 
Sounds like a plugin. Maybe the one you can download from here: Bug 87537 ?
Comment 6 Denis Roy CLA 2009-08-30 02:06:35 EDT 
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.