Bug 122894 - [ast] Refactor ASTNode#is*UseDeprecated methods
Summary: [ast] Refactor ASTNode#is*UseDeprecated methods
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-06 05:59 EST by Maxime Daniel CLA
Modified: 2016-01-14 12:59 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2006-01-06 05:59:22 EST
Code based, org.eclipse.jdt.internal.compiler.ast.ASTNode 1.56
The isFieldUseDeprecated, isMethodUseDeprecated and isTypeUseDeprecated were initially meant to provide information about deprecation only. Deprecation and access restriction being similar in many respects, it made sense to combine checks for those two aspects, and those methods now carry the additional responsibility of access restrictions checks. We are somewhat only at the half of the journey though, since the method names are no more reflecting what is done, on the one hand, and deprecation and access restrictions checks leave the responsibility to raise errors to different parties (the caller for the former, the implementor for the latter). The situation calls for some refactoring.
Philippe's advice is to consider what is done about cast checks.
Comment 1 Maxime Daniel CLA 2006-11-28 12:00:38 EST
Frédéric, do you want me to give it a try, or should I reassign this bug to you?
Comment 2 Maxime Daniel CLA 2006-11-29 03:26:00 EST
Ooops... Frédéric rightly remarks that this is not in his scope.
Start over...
Philippe, do you want me to give it a try, or should I reassign this bug to
you?