Bug 122767 - Do not throw NullPointerException from RulerGridPropertySection
Summary: Do not throw NullPointerException from RulerGridPropertySection
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: ---   Edit
Assignee: Tom Macdougall CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-01-05 11:15 EST by Alex Shatalin CLA
Modified: 2006-09-11 00:05 EDT (History)
0 users

See Also:


Attachments
patch for NPE caused when disposing ruler and grid property section (2.92 KB, patch)
2006-01-06 14:52 EST, Tom Macdougall CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Shatalin CLA 2006-01-05 11:15:52 EST
- Open diagram.
- Open properties view.
- Select Diagram -> Rullers & Grid tab appear
- Select any other diagram element -> error message with an exception will be printed into Error Log view:

java.lang.NullPointerException
	at org.eclipse.gmf.runtime.diagram.ui.properties.sections.grid.RulerGridPropertySection.getWorkspaceViewerProperties(RulerGridPropertySection.java:657)
	at org.eclipse.gmf.runtime.diagram.ui.properties.sections.grid.RulerGridPropertySection.removeWorkspacePropertyListener(RulerGridPropertySection.java:735)
	at org.eclipse.gmf.runtime.diagram.ui.properties.sections.grid.RulerGridPropertySection.dispose(RulerGridPropertySection.java:520)
	at org.eclipse.wst.common.ui.properties.internal.view.Tab$2.run(Tab.java:110)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
	at org.eclipse.core.runtime.Platform.run(Platform.java:785)
	at org.eclipse.wst.common.ui.properties.internal.view.Tab.dispose(Tab.java:117)
	at org.eclipse.wst.common.ui.properties.internal.provisional.TabbedPropertySheetPage.disposeTabs(TabbedPropertySheetPage.java:554)
	at org.eclipse.wst.common.ui.properties.internal.provisional.TabbedPropertySheetPage.updateTabs(TabbedPropertySheetPage.java:608)
	at org.eclipse.wst.common.ui.properties.internal.provisional.TabbedPropertySheetPage.setInput(TabbedPropertySheetPage.java:648)
	at org.eclipse.wst.common.ui.properties.internal.provisional.TabbedPropertySheetPage.selectionChanged(TabbedPropertySheetPage.java:512)
	at org.eclipse.gmf.runtime.diagram.ui.properties.views.PropertiesBrowserPage.selectionChanged(PropertiesBrowserPage.java:356)
	at org.eclipse.ui.views.properties.PropertySheet.selectionChanged(PropertySheet.java:212)
	at org.eclipse.ui.internal.AbstractSelectionService.fireSelection(AbstractSelectionService.java:156)
	at org.eclipse.ui.internal.AbstractSelectionService$1.selectionChanged(AbstractSelectionService.java:62)
	at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramGraphicalViewer.flushSelectionEvents(DiagramGraphicalViewer.java:130)
	at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramGraphicalViewer$1.run(DiagramGraphicalViewer.java:108)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3262)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2908)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1762)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1726)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:397)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143)
	at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:106)
	at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:109)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:68)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:379)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:177)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.core.launcher.Main.invokeFramework(Main.java:338)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:282)
	at org.eclipse.core.launcher.Main.run(Main.java:977)
	at org.eclipse.core.launcher.Main.main(Main.java:952)


Seems like the problem is: RulerGridPropertySection.setInput(IWorkbenchPart part, ISelection selection) was never called. Looks like this problem was introduced by latest changes: https://bugs.eclipse.org/bugs/show_bug.cgi?id=111902
Comment 1 Tom Macdougall CLA 2006-01-06 14:52:56 EST
Created attachment 32616 [details]
patch for NPE caused when disposing ruler and grid property section
Comment 2 Tom Macdougall CLA 2006-01-06 14:59:41 EST
Committed the code
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug