Comment 1 Matthew Webster 2006-01-05 06:41:03 EST

Created attachment 32514 [details]
Testcase

Comment 2 Helen Beeken 2006-02-17 09:21:01 EST

I'm not sure this verify error only occurs when the @AfterReturning advice affects itself that throws an exception. I think it's to do with the extra JoinPoint argument in the list of method args. I've been able to reproduce the problem by running the following:

---------------------------------------------------------------------------

import org.aspectj.lang.JoinPoint;
import org.aspectj.lang.annotation.AfterThrowing;
import org.aspectj.lang.annotation.Aspect;

@Aspect
public class A {
	
	public static void main(String[] args) {
		try {
			new B().start();
		} catch (Exception e) {
			e.printStackTrace();
		}
	}
	
	@AfterThrowing(pointcut = "execution(public void B.start())", throwing = "ex")
	public void handleException(JoinPoint jp, Exception ex) {	
	}

}

class B implements I {
	public void start() throws Exception {
		throw new IllegalArgumentException();
	}	
}

interface I {
	public void start() throws Exception;
}

---------------------------------------------------------------------------------------------------

Changing the @AfterThrowing advice to:

	@AfterThrowing(pointcut = "execution(public void B.start())", throwing = "ex")
	public void handleException(Exception ex) {	
	}

and then rerunning does not result in a verify error.

Looking at the output from decompiling B when there is a verify error, the Exception table for the start() method has 

  Exception table:
   from   to  target type
     9    17    17   Class org/aspectj/lang/JoinPoint

which would result in a verify error saying that the type isn't a subclass of Throwable.

Comment 3 Helen Beeken 2006-02-17 09:30:22 EST

Created attachment 34912 [details]
patch containing failing testcase

Apply to the tests project.

Testcase mentioned in previous comment.

Comment 4 Helen Beeken 2006-02-20 05:23:21 EST

The problem is that Advice.getExtraParameterType() returns the UnresolvedType corresponding to the first argument, so in the example aspect this is org.aspectj.lang.JoinPoint. The fix is to make allowances for the extra parameter corresponding to JoinPoint in the case of annotation style aspects.

Advice.getExtraParameterType() is used in the processing of the extra parameter both for after throwing and after returning advice. Currently if used with the following advice:

@AfterReturning(pointcut = "execution(public B1 B1.start())", returning = "r")
public void afterJP(JoinPoint jp, B1 r) {
     r.stop();
}

it results in a verify error of the form:

Exception in thread "main" java.lang.VerifyError: (class: B1, method: start signature: ()LB1;) Incompatible argument to function at A1.main(A1.java:9)

Comment 5 Helen Beeken 2006-02-20 05:26:36 EST

Created attachment 34995 [details]
patch containing failing testcase for @AfterThrowing and @AfterReturning

Apply this patch to the tests project.

This patch replaces the previously attached one as it improves on the tests for @AfterThrowing and adds tests for @AfterReturning.

Comment 6 Helen Beeken 2006-02-20 05:36:29 EST

Created attachment 34996 [details]
patch containing proposed fix

Apply to the weaver project.

Patch containing proposed fix mentioned above.

Comment 7 Andrew Clement 2006-02-21 11:11:39 EST

fix committed.

Comment 8 Andrew Clement 2006-02-22 04:03:15 EST

fix available.