Bug 122615 - validate classpath propose to exlude a source folder even though exlusion patterns are disabled
Summary: validate classpath propose to exlude a source folder even though exlusion pat...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M5   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 122505
  Show dependency tree
 
Reported: 2006-01-04 07:02 EST by Benno Baumgartner CLA
Modified: 2006-02-14 07:10 EST (History)
0 users

See Also:

Attachments
proposed fix (3.64 KB, patch)
2006-01-04 07:03 EST, Benno Baumgartner CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2006-01-04 07:02:15 EST 
Version: 3.2.0
Build id: I20060103-0800

Given a project with the project folder as root. When calling JavaConventions#validateClasspath with a new source folder class path entry the returned status is an error saying something like: Cannot nest 'P01/src' inside 'P01'. To enable the nesting exclude 'src/' from 'P01'

But excluding a source folder is only possible if the use of exclusion patterns is enabled. If exclusion patterns are disabled the message should read something like: Cannot nest 'P01/src' inside 'P01'.
Comment 1 Benno Baumgartner CLA 2006-01-04 07:03:39 EST 
Created attachment 32459 [details]
proposed fix
Comment 2 Philipe Mulet CLA 2006-01-05 06:19:59 EST 
I wonder which setting is stronger. Maybe the right fix for the user is to enable exclusion patterns instead... By indicating need for excluding, we give a clue about the existence of this feature. Maybe we only need to adjust the wording to account for the fact the excluding is an optional feature (ON by default).
Comment 3 Benno Baumgartner CLA 2006-01-10 03:36:20 EST 
That whould be great too. Maybe something like:

To enable the nesting enable exlusion patterns in project P01 and exlude src from P01.
Comment 4 Jerome Lanneluc CLA 2006-01-18 07:26:53 EST 
Thanks for the patch. Released it with the message:
Cannot nest 'P01/src' inside 'P'. To allow the nesting enable use of exclusion patterns in the preferences of project 'P01' and exclude 'src/' from 'P01'

Added regression test ClasspathTests#testClasspathValidation42()
Comment 5 Frederic Fusier CLA 2006-02-14 07:10:44 EST 
Verified for 3.2 M5 using build I20060214-0010.