Bug 122016 - CreateUnspecifiedTypeRequest should setSize for all the wrapped requests
Summary: CreateUnspecifiedTypeRequest should setSize for all the wrapped requests
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal
Target Milestone: ---   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-23 10:44 EST by Alex Shatalin CLA
Modified: 2006-01-11 10:35 EST (History)
0 users

See Also:

Attachments
Fix is attached (1.45 KB, patch)
2005-12-23 10:45 EST, Alex Shatalin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Shatalin CLA 2005-12-23 10:44:09 EST 
CreateUnspecifiedTypeRequest override setLocation() and call setLocation() for all the wrapped requests, but do not override setSize() method. As a result, al the wrapped requests (passed to the command to process in future) do not get an information about actual size of object to be created.

As a result, all the diagram elements will be created with default sizes, instead of selected with the creation tool.
Comment 1 Alex Shatalin CLA 2005-12-23 10:45:54 EST 
Created attachment 32203 [details]
Fix is attached
Comment 2 Cherie Revells CLA 2006-01-11 10:35:32 EST 
Added propogation of size, creation factory, and extended data to the individual requests in a CreateUnspecifiedTypeRequest.

Activities: 
Bugzilla#122016 gmf_head cmahoney 060112 CreateUnspecifiedTypeRequest should setSize for all the wrapped requests

Code Reviewed by:
Tom

How tested: 
- Tested with the polygon geoshape unspecified creation tool.
- Added a new JUnit, RequestTests, to test this API.

JUnit Tests:  
org.eclipse.gmf.tests.runtime.diagram.ui -- 74/74
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug