Bug 121945 - CanonicalConnectionEditPolicy#getConnectorViews has wrong assumptions
Summary: CanonicalConnectionEditPolicy#getConnectorViews has wrong assumptions
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P1 major
Target Milestone: ---   Edit
Assignee: Steven R. Shaw CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-12-22 20:03 EST by Steven R. Shaw CLA
Modified: 2010-07-19 12:27 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steven R. Shaw CLA 2005-12-22 20:03:22 EST 
- This method is assuming that connections are always owned by Diagram view.
- This is also non-performant if every synchronization of individual canonical containers is reaching to the diagram for list of available views.
Comment 1 Steven R. Shaw CLA 2005-12-22 20:42:19 EST 
- Changed CanonicalConnectionEditPolicy#getConnectionViews to remove assumption that all connection in the diagram are owned by the diagram.  The assumption might not be true in different DSM editors.  Also, it is not performant to always parse all connections in the diagram to canonically synchronize a single compartment within the diagram.
- Demoted old assumption to activity diagram which is synchronizing connections that aren't connected to any node with-in the partition.

API Change:
Deprecated -->
CanonicalConnectionEditPolicy#shouldIncludeConnection(Edge connection, List children)
Replace with -->
CanonicalConnectionEditPolicy#shouldIncludeConnection(Edge connection, Collection children)
Comment 2 Eclipse Webmaster CLA 2010-07-19 12:27:25 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug