Bug 121457 - Consider removing org.eclipse.gmf.runtime.diagram.ui.util.DrawConstant
Summary: Consider removing org.eclipse.gmf.runtime.diagram.ui.util.DrawConstant
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P3 normal
Target Milestone: 1.0   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-12-19 15:16 EST by Cherie Revells CLA
Modified: 2010-07-19 12:29 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2005-12-19 15:16:52 EST 
We should consider removing org.eclipse.gmf.runtime.diagram.ui.util.DrawConstant.  I think we could use org.eclipse.draw2d.PositionConstants instead.
Comment 1 Cherie Revells CLA 2006-01-23 15:56:55 EST 
Description:
- The DrawConstant class is basically a duplicate of GEF's PositionConstants class so it is being removed and we recommend using the PositionConstants class instead.
- References in GMF have been changed.  The only public API references were in IBorderItemLocator and BorderItemLocator.

New API Availability: 
now

Old API Removal: 
Feb 17, 2006 

Other Clients' Action: 
Change references to DrawConstant to be an int from org.eclipse.draw2d.PositionConstants.

IBorderItemLocator
public DrawConstant getCurrentSide() 
--> public int getCurrentSideOfParent()

BorderItemLocator
public BorderItemLocator(IFigure parentFigure, DrawConstant preferredSide) 
--> public BorderItemLocator(IFigure parentFigure, DrawConstant preferredSide)

public static DrawConstant findClosestSide(Rectangle proposedLocation, Rectangle parentBorder) 
--> public static int findClosestSideOfParent(Rectangle proposedLocation, Rectangle parentBorder)

protected Point getPreferredLocation(DrawConstant side, IFigure borderItem) 
--> protected Point getPreferredLocation(int side, IFigure borderItem)

public DrawConstant getPreferredSide() 
--> public int getPreferredSideOfParent()

public void setPreferredSide(DrawConstant preferredSide) 
--> public void setPreferredSideOfParent(int preferredSide)

public DrawConstant getCurrentSide() 
--> public int getCurrentSideOfParent()

public void setCurrentSide(DrawConstant side) 
--> public void setCurrentSideOfParent(int side)
Comment 2 Richard Gronback CLA 2008-08-13 13:06:56 EDT 
[target cleanup] 1.0 M5 was the original target milestone for this bug
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:29:23 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug