Community
Participate
Working Groups
Running the CHKPII and SEGCHK tools on the GMF code reveals some errors and warnings in GMF. I ran the tools on all GMF plugins. Error: 914 Separator between string ID and text should be '****'. May be invalid text continuation. Line: **** Files: A couple diagram example plugin's messages.properties and plugin.properties Fix: Contained ':' instead of '='. Easy to fix. Error: 910 Invalid comment delimiter (/*) used in PropertyResourceBundle. Files: A couple diagram example plugin's plugin.properties and plugin.properties Fix: Remove the invalid comments. Easy to fix. Warning: 920 (W) Unknown single quote handling for this file. Special NLS_MESSAGEFORMAT comment should be added. Files: In all(?) messages.properties and plugin.properties files. Fix: Need to include a NLS_MESSAGEFORMAT comment in each messages.properties file to indicate how single quotes should be handled. Depends on if we are using MessageFormat class or not so we should sweep to make sure we are no longer using this class (we can use the NLS class now). I'll have to read into this more to figure out what NLS_MESSAGEFORMAT comment we should include, but it should be a relatively easy fix. Warning: 131 (W) SegChk SE0006 Isolated coordinating conjunction "and" found. Files: a few messages.properties files Fix: There are some "and"'s alone in the messages.properties file which means they are being concatenated incorrectly somewhere. These need to be changed.
Fixed CHKPII and SEGCHK errors in *.properties file and patched up java files to match if necessary in all the GMF runtime and emft plugins. CHKPII still shows an error in OCLMESSAGES.PROPERTIES, but it has been manually verified and is ok.
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug