Bug 121452 - Fix *.properties files for CHKPII and SEGCHK
Summary: Fix *.properties files for CHKPII and SEGCHK
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P1 critical
Target Milestone: ---   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-19 14:19 EST by Cherie Revells CLA
Modified: 2010-07-19 12:26 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2005-12-19 14:19:21 EST
Running the CHKPII and SEGCHK tools on the GMF code reveals some errors and warnings in GMF.  I ran the tools on all GMF plugins.

Error:  914      Separator between string ID and text should be '****'.  May be invalid text continuation.  Line: ****
Files:  A couple diagram example plugin's messages.properties and plugin.properties 
Fix:  Contained ':' instead of '='.  Easy to fix.

Error: 910   Invalid comment delimiter (/*) used in PropertyResourceBundle.
Files:  A couple diagram example plugin's plugin.properties and plugin.properties 
Fix:  Remove the invalid comments.  Easy to fix.

Warning:  920      (W) Unknown single quote handling for this file.  Special NLS_MESSAGEFORMAT comment should be added.
Files:  In all(?) messages.properties and plugin.properties files.
Fix:   Need to include a NLS_MESSAGEFORMAT comment in each messages.properties file to indicate how single quotes should be handled.  Depends on if we are using MessageFormat class or not so we should sweep to make sure we are no longer using this class (we can use the NLS class now).  I'll have to read into this more to figure out what NLS_MESSAGEFORMAT comment we should include, but it should be a relatively easy fix.

Warning:  131   (W) SegChk SE0006  Isolated coordinating conjunction "and" found.  
Files: a few messages.properties files
Fix:  There are some "and"'s alone in the messages.properties file which means they are being concatenated incorrectly somewhere.  These need to be changed.
Comment 1 Cherie Revells CLA 2006-01-11 19:01:31 EST
Fixed CHKPII and SEGCHK errors in *.properties file and patched up java files to match if necessary in all the GMF runtime and emft plugins.

CHKPII still shows an error in   OCLMESSAGES.PROPERTIES, but it has been manually verified and is ok.
Comment 2 Eclipse Webmaster CLA 2010-07-19 12:26:00 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug