Bug 121312 - [performance]Contribution: Refactoring to Support LTW World with Reflection Delegates for Bootstrap Types
Summary: [performance]Contribution: Refactoring to Support LTW World with Reflection D...
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 1.5.2   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-17 02:53 EST by Ron Bodkin CLA
Modified: 2012-04-03 16:15 EDT (History)
0 users

See Also:

Attachments
Weaver module patch to allow a reflective LTW world. (21.59 KB, patch)
2005-12-17 03:12 EST, Ron Bodkin CLA 		no flags Details | Diff
Patch to loadtime module for reflective LTW world implementation (1.26 KB, patch)
2005-12-17 03:13 EST, Ron Bodkin CLA 		aclement: iplog+
Details | Diff
Weaver module patch to allow a reflective LTW world. (20.82 KB, patch)
2005-12-17 03:35 EST, Ron Bodkin CLA 		aclement: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Bodkin CLA 2005-12-17 02:53:28 EST 
This patch adds an IReflectionWorld interface, changes the various places in code where casts are made to ReflectionWorld to use that interface, creates some common methods and creates an LTWWorld that implements this interface, and sets up the ClassLoaderWeavingAdaptor to use it. It's important that the LTWWorld have just one type map for performance and memory efficiency.
Comment 1 Ron Bodkin CLA 2005-12-17 03:12:18 EST 
Created attachment 31898 [details]
Weaver module patch to allow a reflective LTW world.
Comment 2 Ron Bodkin CLA 2005-12-17 03:13:19 EST 
Created attachment 31900 [details]
Patch to loadtime module for reflective LTW world implementation
Comment 3 Ron Bodkin CLA 2005-12-17 03:20:08 EST 
The LTWTests pass on a 1.4 VM but they fail in Eclipse on a 1.5 VM because org.aspectj.weaver.reflect.Java15ReflectionBasedReferenceTypeDelegate is not on the classpath for the tests module...
Comment 4 Ron Bodkin CLA 2005-12-17 03:35:29 EST 
Created attachment 31901 [details]
Weaver module patch to allow a reflective LTW world.

Fixes bug in Java 1.4 implementation
Comment 5 Andrew Clement CLA 2006-02-23 06:32:51 EST 
I'm a little confused by the patch for loadtime ... since it just adds one commented out line?!?  I presume it is meant to include the change to use LTWWorld?

I'm committed the other changes - but I really would like some kind of testcase that verifies it at least behaves itself...
Comment 6 Wes Isberg CLA 2006-05-10 11:19:21 EDT 
Andy has asked for a test, but Ron produced none.  This should be closed as stalebug since the patch has been committed after the need for a test has been recorded elsewhere.  If we had a tests module in bugzilla, I'd just reassign this.
Comment 7 Andrew Clement CLA 2006-06-27 10:40:47 EDT 
presumed dealt with...