Bug 120699 - Downloadable server adapters should be listed with existing adapters
Summary: Downloadable server adapters should be listed with existing adapters
Status: CLOSED WONTFIX
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 1.0.1   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Tim deBoer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 154370 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-12-13 15:12 EST by Sachin Patel CLA
Modified: 2008-01-08 11:35 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sachin Patel CLA 2005-12-13 15:12:43 EST
Users should not have to go to a second wizard page to show a list of external server adapters.  The "click here if you don't see your server listed" link could easily be overlooked.  It would be much better if all server adapters where listed togather, but some type of graphical indicator on the "external" ones which indicate that a download must occur.
Comment 1 Sachin Patel CLA 2006-01-30 15:10:57 EST
I found the cause for the second start...

The problem is in Server.restart() in the "Restart Thread"

Thread t = new Thread("Restart thread") {
    public void run() {
        try {
            Thread.sleep(250);
        } catch (Exception e) {
            // ignore
        }
        if (ServerPreferences.getInstance().isAutoPublishing() && shouldPublish()) {
            publish(PUBLISH_INCREMENTAL, null);
        }
        try {
            Server.this.start(mode3, listener2);
        } catch (Exception e) {
            Trace.trace(Trace.SEVERE, "Error while restarting server", e);
        }
        }
};

what happens is since Debug On Server is called... publish gets called since a publish is needed which
in turn invokes a syncronous start.

Then server.start gets called, attempting to start the server again.

I think the second called needs to be in an else statement. Submitting a patch.
Comment 2 Sachin Patel CLA 2006-01-30 15:11:34 EST
Oh woops commented on the wrong defect... sorry!
Comment 3 Tim deBoer CLA 2006-08-18 12:59:02 EDT
*** Bug 154370 has been marked as a duplicate of this bug. ***
Comment 4 Tim deBoer CLA 2007-07-17 16:46:56 EDT
Populating the list of downloadable server adapters currently involves connecting to multiple external Eclipse update sites to check for adapters and compatible versions. As such, getting the full list is at best significantly slower than things like the CVS synchronizing or the CVS repository explorer. During this time not only do we not know what will be available on the remaining update sites (so no part of the list is done until we've gone through all sites), but we can't even get to the server name without significant downloading.

I'd love to find an innovative way to integrate the downloadable servers or make it more intuitive for users, but so far we haven't been able to come up with any usable way to integrate them directly into the list of servers. Therefore I am closing this bug - please feel free to reopen (or open a new bug) if you have any other suggestions on how we might improve this.
Comment 5 Eclipse Webmaster CLA 2007-07-29 09:18:35 EDT
Changing OS from Mac OS to Mac OS X as per bug 185991
Comment 6 Tim deBoer CLA 2008-01-08 11:35:08 EST
Closing bug.