Bug 120693 - Contribution: More Efficient Lint Warnings: ~15% Performance Increase
Summary: Contribution: More Efficient Lint Warnings: ~15% Performance Increase
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5.0RC1   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-13 15:03 EST by Ron Bodkin CLA
Modified: 2012-04-03 15:58 EDT (History)
2 users (show)

See Also:

Attachments
Patch to weaver module that significantly reduces performance impact of supressing lint warnings (about 20%) (3.25 KB, patch)
2005-12-13 15:41 EST, Ron Bodkin CLA 		aclement: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Bodkin CLA 2005-12-13 15:03:54 EST 
In profiling a load-time weaving configuration from HEAD, I found that 9% of total time (over 10% of weaving time) is spent in org.aspectj.weaver.Lint.clearSuppressions(), mostly from use inside BcelClassWeaver.match

I made a small change in the parts of BcelAdvice that clear suppressions to save the list that was cleared and to only clear these. This alone saves about 15% of total CPU time in start up on my sample configuration.
Comment 1 Ron Bodkin CLA 2005-12-13 15:41:03 EST 
Created attachment 31681 [details]
Patch to weaver module that significantly reduces performance impact of supressing lint warnings (about 20%)
Comment 2 Adrian Colyer CLA 2005-12-13 15:52:04 EST 
made it into RC1 by the skin of its teeth! I'm currently testing an almost identical solution to your patch (which I added before the patch was attached to the bug report). If the bar stays green I'll put it in.
Comment 3 Adrian Colyer CLA 2005-12-13 17:27:51 EST 
fix now in tree
Comment 4 Adrian Colyer CLA 2005-12-14 07:05:37 EST 
fix available