Bug 120633 - Accumulate messages issued during WeavingAdaptor intialization of flush if -verbose
Summary: Accumulate messages issued during WeavingAdaptor intialization of flush if -v...
Status: VERIFIED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 1.5.0   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-13 12:16 EST by Matthew Webster CLA
Modified: 2006-08-11 04:28 EDT (History)
0 users

See Also:

Attachments
Modified existing tests and implementation (3.22 KB, application/octet-stream)
2005-12-13 12:21 EST, Matthew Webster CLA 		no flags Details
Updates to LTW section on Development Environment Guide (21.64 KB, application/octet-stream)
2005-12-20 06:50 EST, Matthew Webster CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Webster CLA 2005-12-13 12:16:24 EST 
There are several useful messages issued during adaptor initialization (including the new version string) that are not output unless "-Daj.weaving.verbose=true" because the verbose flag must be read from aop.xml. This enhancement accumulates these messages the outputs them if -verbose is specified. The implementation allows for a futher enhancement where these messages are retained until a warning/error message is issued.
Comment 1 Matthew Webster CLA 2005-12-13 12:21:22 EST 
Created attachment 31653 [details]
Modified existing tests and implementation

1. Enhance WeavingAdaptorMessageHandler to support accumulation and flushing
2. Make WeavingAdaptor.messageHandler private and intercept its update to allow accumulated messaged to be flushed
3. Modify expected output for serveral existing tests to account for the additional messages
Comment 2 Andrew Clement CLA 2005-12-19 16:37:54 EST 
changes committed into HEAD but not into the release branch yet.
Comment 3 Adrian Colyer CLA 2005-12-20 06:14:53 EST 
changes merged into release branch...
Comment 4 Matthew Webster CLA 2005-12-20 06:50:01 EST 
Created attachment 32017 [details]
Updates to LTW section on Development Environment Guide
Comment 5 Andrew Clement CLA 2005-12-21 05:58:04 EST 
all available in 1.5.0 final.