Bug 120363 - LTW weaver include and exclude does not behave correctly
Summary: LTW weaver include and exclude does not behave correctly
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5.0RC1   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-12 08:42 EST by Matthew Webster CLA
Modified: 2005-12-13 11:40 EST (History)
0 users

See Also:

Attachments
Testcase and fix for uding include and exclude together (2.40 KB, application/octet-stream)
2005-12-12 10:19 EST, Matthew Webster CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Webster CLA 2005-12-12 08:42:34 EST 
According to the specification (http://www.eclipse.org/aspectj/doc/next/adk15notebook/ltw-configuration.html) "The set of types to be woven are those types matched by at least one weaver include element and not matched by any weaver exclude element." However if an includ elemement can be fast matched e.g. "com.foo..*" any exclude elements are ignored (see bug 117854). There is no explicit test in the harness for this feature.
Comment 1 Matthew Webster CLA 2005-12-12 10:19:07 EST 
Created attachment 31562 [details]
Testcase and fix for uding include and exclude together

1. Modified dump before and after testcase to weave test but not accompanying "proxy" i.e. class with funny name
2. Fix to ClassLoaderWeavingAdaptor.accept() to only perform fast match for include if there are no exclude patterns.
Comment 2 Andrew Clement CLA 2005-12-12 10:41:26 EST 
patches checked in.
Comment 3 Andrew Clement CLA 2005-12-13 11:40:08 EST 
fix available.