Bug 120092 - [search] Java like extensions functionality causes performance issue for search engine
Summary: [search] Java like extensions functionality causes performance issue for sear...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-12-09 06:50 EST by Frederic Fusier CLA
Modified: 2005-12-13 12:31 EST (History)
1 user (show)

See Also:

Attachments
Patch to fix this issue (5.48 KB, patch)
2005-12-09 11:40 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2005-12-09 06:50:12 EST 
Using build I20051206-1200.

This build shows performance issues for Search test suite (time increased over 10%).

After having investigated, it seems that origin is in findClass(...) method of ClasspathSourceDirectory class. Time to find class is multiplied by the number of java like extensions. We need to improve this method to reduce side effect (or make it null) of Java Like Extensions functionality...
Comment 1 Frederic Fusier CLA 2005-12-09 11:40:02 EST 
Created attachment 31480 [details]
Patch to fix this issue
Comment 2 Frederic Fusier CLA 2005-12-09 11:43:27 EST 
Patch released in HEAD.

Here are performance results I got:
Test	Index	Names	Types 	Fields	Methods	Constr.
v_626	1.15%	0.53%	-14.97%	-15.32%	1.13%	-12.20%
Patch	0.95%	0.97%	30.67%	48.28%	2.18%	41.08%

Sounds a little bit strange to gain so much. I'll wait M4 warmup before drinking champagne...;-)

Many thanks to Jerome who helped me a lot here... :-)
Comment 3 Jerome Lanneluc CLA 2005-12-09 11:45:57 EST 
Hey, I introduced the regression, so I was expected to help.
Comment 4 Frederic Fusier CLA 2005-12-09 12:12:53 EST 
After another run on v_627 just done, results sound more reasonable:

Test    Index   Names   Types   Fields  Methods Constr.
v_627	0.66%	1.02%	-1.59%	3.20%	2.37%	1.31%

They still show that problem is really fixed but not so greatfully as I initially thought...
Comment 5 Jerome Lanneluc CLA 2005-12-13 12:31:14 EST 
Verified for 3.2 M4 using build I20051213-0010