Bug 120091 - Review isMissing calls through the codebase.
Summary: Review isMissing calls through the codebase.
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.5.1   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-09 05:53 EST by Andrew Clement CLA
Modified: 2006-10-02 06:37 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2005-12-09 05:53:49 EST
For 118754 I have committed a change to modify checks like this:

'type == MISSING'

to be

'type.isMissing()'

this was required for LTW.  It may impact the ability for us to proceed with MissingWithKnownSignature types since they return 'true' for isMissing() but don't pass the 'type==MISSING' test.  When Ron complains about new bunches of cant find type messages, we should look at where they are are change the isMissing calls to isReallyMissing() or something similar.

The tests all passed with the above change in place, so I can only assume we don't have anything that verifies the right number of cant find type messages come out when weaving something when we don't know all its dependencies.
Comment 1 Andrew Clement CLA 2006-02-15 05:28:17 EST
placeholder bug for googling in the future :)  Closing
Comment 2 Andrew Clement CLA 2006-04-04 14:20:40 EDT
closing.
Comment 3 Helen Beeken CLA 2006-10-02 06:37:47 EDT
Just as a note...the referenced bug is bug 117854 (not 118754).