Bug 119857 - [javadoc] Some inner class references should be flagged as unresolved
Summary: [javadoc] Some inner class references should be flagged as unresolved
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 148968 (view as bug list)
Depends on: 96237
Blocks:
  Show dependency tree
 
Reported: 2005-12-08 08:34 EST by Dani Megert CLA
Modified: 2006-08-04 09:03 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-12-08 08:34:39 EST 
I20051206-1200

I enabled all Javadoc warnings from JDT Core and no problems get reported for org.eclipse.jface.text.DefaultInformationControl rev. 1.26 but during the releng build warnings are reported:
http://download.eclipse.org/eclipse/downloads/drops/N20051208-0010/compilelogs/platform.doc.isv.javadoc.txt
Comment 1 Frederic Fusier CLA 2005-12-08 10:42:22 EST 
Not really a duplicate of 96237. Here's the problem comes from the fact that reference is done on an inner class context to another inner class at same level.
It seems that javadoc.exe is not able to use enclosing type to retrieve this kind of reference... We have to make our compiler less smarter...:-(

Here's a smaller test case:
/**
 * @see MyInnerClass
 * @see MyInnerClass#foo()
 * @see MyInnerInterface
 * @see MyInnerInterface#foo()
 */
public class Test {
	/**
	 * @see MyInnerInterface
	 * @see MyInnerInterface#foo()
	 */
	public class MyInnerClass {
		public void foo() {}
	}
	/**
	 * @see MyInnerClass
	 * @see MyInnerClass#foo()
	 */
	public interface MyInnerInterface {
		public void foo();
	}
}

javadoc.exe produces following warnings:
Test.java:12: warning - Tag @link: reference not found: MyInnerInterface
Test.java:12: warning - Tag @link: reference not found: MyInnerInterface#foo()
Test.java:19: warning - Tag @link: reference not found: MyInnerClass
Test.java:19: warning - Tag @link: reference not found: MyInnerClass#foo()

Note that references in first javadoc comment are not flagged as warning
Comment 2 Frederic Fusier CLA 2006-04-12 14:00:23 EDT 
We need first to fix problem with inner classes qualification before fixing this one...
Comment 3 Frederic Fusier CLA 2006-04-26 12:51:11 EDT 
Set same resolution as blocking bug
Comment 4 Frederic Fusier CLA 2006-06-23 03:59:45 EDT 
Note also that these warnings only occurs with 1.4.2 version. There's no warning at all with 1.5.0 version...
Comment 5 Frederic Fusier CLA 2006-06-28 06:56:53 EDT 
*** Bug 148968 has been marked as a duplicate of this bug. ***
Comment 6 Frederic Fusier CLA 2006-07-02 08:34:40 EDT 
Synchronize our compiler behavior on javadoc tool one. It now raises warnings when source is 1.4 and none on 1.5...

Fixed and released for 3.3 M1 in HEAD stream.
Comment 7 Maxime Daniel CLA 2006-08-04 09:03:29 EDT 
Verified for 3.3 M1 using build I20060804-0010.