Bug 119231 - Excessive use of String.replace() in WeavingAdaptor
Summary: Excessive use of String.replace() in WeavingAdaptor
Status: NEW
Alias: None
Product: AspectJ
Classification: Tools
Component: LTWeaving (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-05 06:06 EST by Matthew Webster CLA
Modified: 2009-03-30 09:21 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Webster CLA 2005-12-05 06:06:15 EST 
The interface used by the WeavingAdaptor to weave classes is BcelWeaver.weave(IClassFileProvider). An IClassFileProvider supplies instances of UnwovenClass which can be created using either "." or "/" as the package separator. However in the WeavingAdaptor we assume names use "/" and frequently convert eventhough weaveClass() can be called using either "." (when called directly from a class loader e.g. WeavingURLClassLoader.defineClass()) or "/" (when called from an agent).

We should settle on one form. We can use "." in the adaptor and ensure callers who use "/" conver first.