Bug 119203 - [search] references to method gives many inaccurate matches in Plug-in Dependencies
Summary: [search] references to method gives many inaccurate matches in Plug-in Depend...
Status: RESOLVED DUPLICATE of bug 73957
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 106998 205147 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-12-04 19:00 EST by Markus Keller CLA
Modified: 2008-01-08 05:19 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-12-04 19:00:50 EST 
I20051130-1215

- start eclipse with a new workspace
- create a new Plug-in Project, choose the "Plug-in with an editor" template
- open type "IParameter" and search for references to its getId() method in workspace

=> I get 579 matches in workspace, most of which are inaccurate ("potential" in the Search view)
Comment 1 Frederic Fusier CLA 2005-12-05 15:38:08 EST 
Fixed and released in HEAD.

Problem came from the fact that MatchLocator still try to resolve even after having got an AbortCompilation exception. Seem to be a regression introduced with the fix of bug 86380... :-(

Fortunately while testing fix, it appears that there's a way to test such a problem (ie. AbortCompilation) using our tests => test case added in JavaSearchScopeTests
Comment 2 Frederic Fusier CLA 2005-12-05 15:38:35 EST 
*** Bug 106998 has been marked as a duplicate of this bug. ***
Comment 3 Markus Keller CLA 2005-12-06 05:08:50 EST 
I don't understand why those IClassFiles need to be compiled at all. Is the search engine for references in binary types also source-based? I quickly tried and removed all *.source* plug-ins and then reproduced comment 0, but then I didn't get a single match any more, which would confirm that the class files are not consulted.
Comment 4 Frederic Fusier CLA 2005-12-06 05:56:20 EST 
Yes search engine use attached source of class files when avalaible.
However, it should still find exact matches as class file _are_ consulted when there's no attched source. I'll investigate...
Comment 5 Frederic Fusier CLA 2005-12-06 07:28:19 EST 
This is a current search engine limitation. Class files are consulted but only to report types/methods/fields declaration, not reference.
Please open a new bug if you find this could be an interesting feature...
Comment 6 Jerome Lanneluc CLA 2005-12-13 12:04:03 EST 
Verified for 3.2 M4 using build I20051213-0010
Comment 7 Frederic Fusier CLA 2006-02-10 04:23:56 EST 
Fix for this bug has been removed due to bad side effects (see bug 127048).
Comment 8 Frederic Fusier CLA 2006-02-10 04:28:16 EST 
As said in bug 127048 comment 5, there's nothing else search engine can do without bindings than reporting potential matches...
So, set this bug as duplicate bug 73957, as if classpathes were correct then search engine would report only accurate matches.


*** This bug has been marked as a duplicate of 73957 ***
Comment 9 Frederic Fusier CLA 2008-01-08 05:19:23 EST 
*** Bug 205147 has been marked as a duplicate of this bug. ***