Bug 119108 - Access Rules and Path separators
Summary: Access Rules and Path separators
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Maxime Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 119110
  Show dependency tree
 
Reported: 2005-12-02 15:41 EST by Andrew Niefer CLA
Modified: 2005-12-12 10:56 EST (History)
0 users

See Also:

Attachments
patch (1.02 KB, patch)
2005-12-05 15:32 EST, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2005-12-02 15:41:28 EST 
AccessRuleSet.getViolatedRestriction compares rules against paths using '/' as a path seperator.  The access rule patterns being passed in use '/'.  However, the target file path being matched against may use '\' as the seperator if it is coming out of a directory as opposed to a jar (see FileSystem.findClass).

With recent support from pde.build to support passing access rules, releng builds will be getting many invalid warnings because of this.
Comment 1 Andrew Niefer CLA 2005-12-05 15:32:50 EST 
Created attachment 31145 [details]
patch

This is the patch I've been using to fix this problem in my local workspace.

Is this something we can get fixed for tomorrow's integration build?  Jeff is going to ApacheCon next week and we would like to be able to demo our support for access rules.
Comment 2 Maxime Daniel CLA 2005-12-06 06:56:29 EST 
Fixed and released in HEAD.
Modified AccessRuleSet.getViolatedRestriction to accept '\' in targetTypeFilePath
when running on Windows.
Comment 3 Jerome Lanneluc CLA 2005-12-12 10:56:52 EST 
Verified for 3.2 M4 using build I20051212-0010