Bug 118123 - API breakage after M9
Summary: API breakage after M9
Status: CLOSED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: wst.server CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-11-25 23:14 EST by David Williams CLA
Modified: 2017-10-11 15:54 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2005-11-25 23:14:38 EST
I believe 'members' was removed from ProjectModule and has been causing compile problems with StaticWebDeployable since M9 declared. 

What's up? 

Was the done for "API correctness"? (A little late for that :( 
Was the implementation supposed to be moved to StaticWebDeplyable?

I suggest in either case that a members function could be left in 
ProjectModule and either return an empty array (if that makes any sense as default behavior), 
or throw CoreException (as its spec'd to) with a message that "subclass must implement this method"). 

Also, please note: the "TestProjectModule" returns null, instead of empty array ... so, not sure if that's a sign of lack of testing ... or an incorrect test, but think that should be fixed too.
Comment 1 Tim deBoer CLA 2005-11-27 16:16:01 EST
Sorry, my bad. I was cleaning up some Javadoc and commented out methods and wasn't thinking. I've added the method back to the class and released the changes for the next build.

Luckily, doing this also made me take a look at the current implementation of static web projects, which was evidently broken and completely unusable in M9. I've opened bugs 118161 and 118162 to track the issues.
Comment 2 David Williams CLA 2005-12-18 15:11:33 EST
Confirming as fixed. 
Comment 3 Tim deBoer CLA 2006-11-21 14:28:56 EST
Closing old bugs.
Comment 4 Eclipse Genie CLA 2017-10-11 15:54:22 EDT
New Gerrit change created: https://git.eclipse.org/r/107593