Bug 117324 - memory leak caused by the DefualtProvider
Summary: memory leak caused by the DefualtProvider
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 critical
Target Milestone: ---   Edit
Assignee: Steven R. Shaw CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-11-21 11:19 EST by Mohammed Mostafa CLA
Modified: 2010-07-19 12:28 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mohammed Mostafa CLA 2005-11-21 11:19:45 EST 
The DefaultProvider had a member IMapMode mm decalred on it and at one point this member points to DiagramRenderedScalableFreeformLayeredPane which had pointer to the DiagramEditPart

this will result in keeping the DiagramEditPart and the DIagram View with all of its children from being collected by the GC, even if you close the diagram and even the project that contains the model containing the Diagram

In general i think the providers whould not have any state variable on them cause they will stay in memmory till some one NULLs them
Comment 1 Steven R. Shaw CLA 2005-11-21 12:01:56 EST 
- Instance of IMapMode was being cached that was implemented by the ScalableFreeformLayeredPane which is help onto by the DiagramRootEditPart which is held by the Editor thereby causing an Editor leak (== bad).  Made sure to null the cached variable before exiting the DefaultProvider api.
Comment 2 Eclipse Webmaster CLA 2010-07-19 12:28:32 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug