Bug 115905 - ShapeCompartment collapse handle drawn outside shapecomartment figure
Summary: ShapeCompartment collapse handle drawn outside shapecomartment figure
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0.1   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-11-10 15:35 EST by Michael Hanner CLA
Modified: 2010-07-19 12:28 EDT (History)
2 users (show)

See Also:

Attachments
fix for ResizableCompartmentEditPolicy (9.06 KB, patch)
2006-08-30 18:29 EDT, Alex Boyko CLA 		no flags Details | Diff
Revised and reviews fix (10.35 KB, patch)
2006-08-31 17:08 EDT, Alex Boyko CLA 		no flags Details | Diff
updated patch (9.65 KB, patch)
2006-09-06 11:09 EDT, Alex Boyko CLA 		no flags Details | Diff
corrected (10.46 KB, patch)
2006-09-15 19:12 EDT, Alex Boyko CLA 		no flags Details | Diff
final patch (14.86 KB, patch)
2006-09-18 12:24 EDT, Alex Boyko CLA 		no flags Details | Diff
patch corrected and optimized (14.87 KB, patch)
2006-09-18 20:55 EDT, Alex Boyko CLA 		no flags Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hanner CLA 2005-11-10 15:35:31 EST 
When an shapecompartment figure is placed on a diagram, and it is made very 
small, the compartment control (the little triangle controlling whether a 
compartment is show or collapsed) will end up outside of the shape.
Comment 1 Alex Boyko CLA 2006-08-30 18:29:32 EDT 
Created attachment 49110 [details]
fix for ResizableCompartmentEditPolicy

An attempt to fix this issue. Modified ResizableCompartmentEditPolicy to draw or erase handles depending on the sizes of compartment figure and its container. Code hasn't been reviewed yet.
Comment 2 Alex Boyko CLA 2006-08-31 17:08:18 EDT 
Created attachment 49217 [details]
Revised and reviews fix

The fix for the bug. Includes the fix for an issue with making comaprtments visiible/invisible, i.e. listener to the visibility event is removed.
Fix with 2 figure listeners. each figureMoved event takes up for about 8000-20000 nano seconds.
Reviewed and can be commited.
Comment 3 Alex Boyko CLA 2006-09-05 16:02:24 EDT 
The fix for this bug has been included in the fix for Bugzilla #154531
The modification to the patch uploaded here is instead of creating-adding and removing-deleting collapse handles they are being made visible/invisible when appropriate.
Comment 4 Alex Boyko CLA 2006-09-06 11:09:52 EDT 
Created attachment 49495 [details]
updated patch

The patch that fixes the problem. Ready to be commited.
Comment 5 Alex Boyko CLA 2006-09-06 17:27:29 EDT 
patch is commited, marking as fixed
Comment 6 Cherie Revells CLA 2006-09-15 17:14:27 EDT 
This fix removes the collapse handles when they shouldn't be removed in a client scenario.
Comment 7 Alex Boyko CLA 2006-09-15 19:12:28 EDT 
Created attachment 50315 [details]
corrected

Here is a much better patch with a correct condition for hiding the handles. (also no figure listeners). Tested with the client application, so far no problems noticed
Comment 8 Alex Boyko CLA 2006-09-15 19:13:55 EDT 
added Cherie in CC, since she noticed that the previous fix was insufficient
Comment 9 Alex Boyko CLA 2006-09-18 12:24:23 EDT 
Created attachment 50393 [details]
final patch

Here is the final patch.
Moved showing/hiding logic from CompartmentCollapseHandle into CollapseFigure. Manually tested with the client application - no problems noticed.
Comment 10 Alex Boyko CLA 2006-09-18 20:55:56 EDT 
Created attachment 50436 [details]
patch corrected and optimized

Optimized condition
Comment 11 Cherie Revells CLA 2006-09-19 17:11:51 EDT 
Committed the new patch.
Comment 12 Eclipse Webmaster CLA 2010-07-19 12:28:59 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug