Bug 114909 - AST: String concatenation represented as single node
Summary: AST: String concatenation represented as single node
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-03 09:19 EST by Markus Keller CLA
Modified: 2005-12-12 11:35 EST (History)
1 user (show)

See Also:

Attachments
Proposed fix (5.66 KB, patch)
2005-11-03 12:05 EST, Olivier Thomann CLA 		no flags Details | Diff
Regression test (5.52 KB, patch)
2005-11-04 04:29 EST, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2005-11-03 09:19:38 EST 
I20051102-1600

It looks like bug 82830 has only been paralyzed and now crept back into the
build again.
Comment 1 Jerome Lanneluc CLA 2005-11-03 09:27:39 EST 
The regression test for bug 82830 is still passing, indicating that an infix
expression is built for a string concatenation. Do you have more details ?
Comment 2 Olivier Thomann CLA 2005-11-03 09:36:54 EST 
Indeed, using the ASTView in I20051102-1200 produces a single string literal in
reconcile mode
Comment 3 Olivier Thomann CLA 2005-11-03 10:14:05 EST 
I will investigate.
Comment 4 Olivier Thomann CLA 2005-11-03 11:21:13 EST 
The path that doesn't work is a BecomeWorkingCopyOperation followed by a reconcile.
In this case the string literals are optimized.
Comment 5 Olivier Thomann CLA 2005-11-03 12:05:44 EST 
Created attachment 29274 [details]
Proposed fix
Comment 6 Jerome Lanneluc CLA 2005-11-04 04:29:06 EST 
Created attachment 29313 [details]
Regression test
Comment 7 Jerome Lanneluc CLA 2005-11-04 10:44:34 EST 
Release proposed fix and regression test in HEAD.
Comment 8 David Audel CLA 2005-12-12 11:35:24 EST 
Verified for 3.2 M4 using build I20051212-0010