Bug 114080 - Import Plugin Filtering Incorrect
Summary: Import Plugin Filtering Incorrect
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: bartosz michalik CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2005-10-28 06:43 EDT by Jan Haensli CLA
Modified: 2007-12-11 13:48 EST (History)
5 users (show)

See Also:

Attachments
testplugin 1.0.9 (537 bytes, application/octet-stream)
2005-10-28 06:44 EDT, Jan Haensli CLA 		no flags Details
testplugin 1.0.10 (537 bytes, application/octet-stream)
2005-10-28 06:45 EDT, Jan Haensli CLA 		no flags Details
mylyn/context/zip (962 bytes, application/octet-stream)
2007-11-02 16:15 EDT, Chris Aniszczyk CLA 		no flags Details
patch proposal (3.56 KB, patch)
2007-11-29 18:31 EST, bartosz michalik CLA 		no flags Details | Diff
mylyn/context/zip (3.16 KB, application/octet-stream)
2007-11-29 18:31 EST, bartosz michalik CLA 		no flags Details
checkbox added (7.08 KB, patch)
2007-11-30 10:58 EST, bartosz michalik CLA 		no flags Details | Diff
mylyn/context/zip (8.00 KB, application/octet-stream)
2007-11-30 10:58 EST, bartosz michalik CLA 		no flags Details
org.eclipse.pde.ui.patch (9.97 KB, patch)
2007-12-03 16:40 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (2.20 KB, application/octet-stream)
2007-12-03 16:40 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Haensli CLA 2005-10-28 06:43:06 EDT 
Plugin file filtering/sorting of versions is incorrect.

Given Problem:
Copy two versions of the same plugin (e.g. com.yourcompany.yourplugin_1.0.9 and
com.yourcompany.yourplugin_1.0.10) in the same folder. The plugin import
selection dialog shows only version 1.0.9.

This probably because the filter shows only the newest version.
But 1.0.9 is older than 1.0.10. I would expect that 1.0.10 is shown instead of
1.0.9. (Correct me if I'm wrong)

Reproduce:
File > Import/Export > External Plug-ins and Fragments > Next
See Attachment for two almost empty testplugins
Comment 1 Jan Haensli CLA 2005-10-28 06:44:15 EDT 
Created attachment 28910 [details]
testplugin 1.0.9

testplugin 1.0.9
Comment 2 Jan Haensli CLA 2005-10-28 06:45:01 EDT 
Created attachment 28911 [details]
testplugin 1.0.10

testplugin 1.0.10
Comment 3 Tobias Widmer CLA 2005-11-18 06:49:44 EST 
Actually there is nothing wrong with showing all versions of a plugin. It would
be convenient to display them with its bundle state (see About -> Configuration
Details).
Comment 4 Chris Aniszczyk CLA 2007-11-02 16:15:00 EDT 
tagging bugday
Comment 5 Chris Aniszczyk CLA 2007-11-02 16:15:13 EDT 
Created attachment 81999 [details]
mylyn/context/zip
Comment 6 bartosz michalik CLA 2007-11-22 03:53:56 EST 
assign it to me :)
Comment 7 Chris Aniszczyk CLA 2007-11-22 15:35:35 EST 
There you go :)
Comment 8 bartosz michalik CLA 2007-11-29 18:31:43 EST 
Created attachment 84113 [details]
patch proposal 

in this proposal filter is always enabled. alternatively I can provide filter that cna be switched using e.g. checkbox below plugins' list.
waiting for comments
Comment 9 bartosz michalik CLA 2007-11-29 18:31:47 EST 
Created attachment 84114 [details]
mylyn/context/zip
Comment 10 Chris Aniszczyk CLA 2007-11-30 05:58:47 EST 
Yes, please add the checkbox and we will call it a day.

It should be checked by default. When unchecked, you'll see everything.

Thanks Bartosz! We can try to get this in for M4.
Comment 11 bartosz michalik CLA 2007-11-30 10:58:18 EST 
Created attachment 84185 [details]
checkbox added

filter works only on foud plug-ins list. waiting for suggestions,
I think that space between should be smaller but this implementation was only chance to not modify other classes
Comment 12 bartosz michalik CLA 2007-11-30 10:58:20 EST 
Created attachment 84186 [details]
mylyn/context/zip
Comment 13 Chris Aniszczyk CLA 2007-12-03 16:40:05 EST 
Created attachment 84360 [details]
org.eclipse.pde.ui.patch

I cleaned up the patch a bit. I reworded the label along with adjusting the layout. I also made sure that the new button didn't suffer from amnesia (ie., use dialog settings).

Thanks for the patch Barotz, this will be useful for people when dealing with multiple versions of plug-ins.
Comment 14 Chris Aniszczyk CLA 2007-12-03 16:40:08 EST 
Created attachment 84361 [details]
mylyn/context/zip
Comment 15 Chris Aniszczyk CLA 2007-12-03 16:40:32 EST 
done.
Comment 16 Brian Bauman CLA 2007-12-11 13:48:24 EST 
verified on I20071211-0010