Bug 113812 - Sweep diagram plugin message bundles
Summary: Sweep diagram plugin message bundles
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P1 major
Target Milestone: 1.0   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-26 10:22 EDT by Steven R. Shaw CLA
Modified: 2010-07-19 12:26 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steven R. Shaw CLA 2005-10-26 10:22:57 EDT 
See bugzilla 109445 for details:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=109445
Comment 1 Steven R. Shaw CLA 2005-10-31 11:10:27 EST 
From Eliza:
Is there a plan item to migrate GMF plug-ins to conform to Eclipse's way of 
getting images (quoting Wayne "E.g. using the imageDescriptorFromPlugin() 
method off AbstractUIPlugin.  For a concrete example, please see 
IDEWorkbenchPlugin.getIDEImageDescriptor())" ?
Comment 2 Cherie Revells CLA 2005-11-25 14:59:03 EST 
Purpose: 
For all GMF diagram plugins: 
- Migrated the retrieval of translated strings to use XMessages mechanism. 
- Migrated the retrieval of images and image descriptors to an XPluginImages class which manages the caching of only frequently used images. 
- Migrated the retrieval of fonts to use an internal FontRegistry class in the draw2d and diagram.ui plugins.  This is used internally only.  We have tried to migrate to JFace FontRegistry in the past, but the font caching is only done at the font level and not on specific sizes of fonts. 
- Moved the getColor() methods in AbstractResourceManager to a DiagramColorRegistry as this was the only thing left in the DiagramResourceManager. 
- Removed all XResourceManagers except for DiagramResourceManager which has been deprecated (see API change notice I just sent). 

Activities: 
Bugzilla#113812 gmf_head cmahoney 051125 Deprecating DiagramResourceManager 

Code Reviewed by: 
Steve 

How tested: 
- Eyeballed the strings and icons in the preference pages, appearance property pages, toolbar, diagram main menu, popup menu, diagram assistants. 
- Adhoc font tests, zoom tests. 
- Adhoc testing in Logic Example, Visualizer, and Modeler. 

Launching org.eclipse.gmf.tests.runtime.diagram.ui 
OK, Runs:        69, Fails:        0, Errors:        0, org.eclipse.gmf.tests.runtime.diagram.ui, Time:        94.266 

Launching org.eclipse.gmf.tests.runtime.draw2d.ui 
OK, Runs:        35, Fails:        0, Errors:        0, org.eclipse.gmf.tests.runtime.draw2d.ui, Time:        0.312 

Launching org.eclipse.gmf.tests.runtime.draw2d.ui.render 
OK, Runs:        3, Fails:        0, Errors:        0, org.eclipse.gmf.tests.runtime.draw2d.ui.render, Time:        5.344
Comment 3 Richard Gronback CLA 2008-08-13 13:06:26 EDT 
[target cleanup] 1.0 M4 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:26:26 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug