Bug 113510 - readAspect
Summary: readAspect
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 1.5.0RC1   Edit
Assignee: Alexandre Vasseur CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-24 05:36 EDT by Alexandre Vasseur CLA
Modified: 2005-11-02 05:36 EST (History)
1 user (show)

See Also:

Attachments
Fix (3.10 KB, application/octet-stream)
2005-11-01 12:33 EST, Matthew Webster CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Vasseur CLA 2005-10-24 05:36:56 EDT 
clearly define what the goal for readAspect is
old byte per byte reading cause NPE in some test case
current impl is hashcode for aspect name + classloader - ie unstable across
startups.
Comment 1 Adrian Colyer CLA 2005-10-28 07:22:39 EDT 
for resolution by rc1...
Comment 2 Matthew Webster CLA 2005-10-31 04:40:57 EST 
This mechanism was added to support byte-code caching in a PoC OSGi 
environment. Actual aspect byte-code was use to determine when an aspect 
implementation had changed as well as the set of aspects affecting a 
particular class loader. However this approach is not sufficient to determine 
all the situations when a byte-code cache should be invalidated so I will 
change the implemtation to one that uses a sorted list of aspect names.
Comment 3 Matthew Webster CLA 2005-11-01 12:33:20 EST 
Created attachment 29081 [details]
Fix

Remove "readAspect()" method and use names instead. Have tested against my PoC
that needs it.
Comment 4 Andrew Clement CLA 2005-11-02 05:36:01 EST 
patch integrated, thanks Matthew.