Bug 113373 - Converting JDT/UI to EFS. Open issues
Summary: Converting JDT/UI to EFS. Open issues
Status: RESOLVED INVALID
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on: 116414
Blocks:
  Show dependency tree
 
Reported: 2005-10-21 12:52 EDT by Dirk Baeumer CLA
Modified: 2009-08-30 02:05 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2005-10-21 12:52:35 EDT
Hi Martin,

enclosed a list of open issues I encountered when converting JDT/UI to use EFS:

Javadoc export wizard
  - assumes that the destination of the export is the local file system. As
    long as this holds no further action is needed.

  - no warnings are generated for source that is not local. The current 
    implementation (as of 3.0) simply ignores them. IMO we should think about
    extending the dialog to present a message box for those locations that got
    ignored

Jar export wizard:
  - assumes that the destination of the export is the local file system. As
    long as this holds no further action is needed.

New Java project wizard:
  - since we don't have any UI yet to specify a location different than in the
    local file system, I haven't adjusted the LocationGroup yet. As soon as 
    Platform/UI has a user interface here we have to see what we have to do.
    However I adapted all the internal code of the wizards to use URI and 
    I currently convert the path provided in the UI into an URI. See method
    JavaProjectWizardSecondPage#getProjectLocationURI()

LinkFolderDialog:
  - same as with the new wizard. If a link can point to a different file
    system we have to adapt the code as soon as Platform/UI provide UI to
    define them.

Build path: I made the following assumptions when converting the code to
  EFS (so the use of getLocation and toFile on Path is still ok):
  - archives as source attachements only support for archiives on local 
    file systems. 
  - class path variables can only point to files and folders on local
    file systems. 

Philippe, be already discussed the source attachement. I assume that the same is
true of class path variables as well. If not, some new API on Core is needed to
map class path variables to URIs.
Comment 1 Dirk Baeumer CLA 2005-10-21 12:53:24 EDT
Philippe, can you please comment on the class path variable case.
Comment 2 Philipe Mulet CLA 2005-10-25 04:34:58 EDT
I confirm. Any external path can only denote a file on the local filesystem. We
may revisit this post 3.2, but this will need to introduce some change (i.e.
allow URI/URL usage on classpath). Internal JARs should however be allowed to
use internal source attachment JARs from EFS.
Comment 3 Martin Aeschlimann CLA 2005-11-14 17:46:56 EST
The Javadoc wizard now warns for non-local files > 20051114

Dirk, is there an existing bug request for the file/folder dialog working on EFS?
Comment 4 Dirk Baeumer CLA 2005-11-15 04:38:46 EST
Not that I am aware of. I discussed it with John Arthorne.
Comment 5 Martin Aeschlimann CLA 2005-11-15 05:10:17 EST
Setting on remind. No further action until either changes in bug 116414 or the
platform's new project page.
Comment 6 Tianchao Li CLA 2006-04-20 14:42:24 EDT
Now that the new resource creation wizards have ui support. I guess it is now the time to (re-)open this bug?

Comment 7 Martin Aeschlimann CLA 2006-04-21 09:30:08 EDT
bug 116414 is on REMIND. I guess no action for 3.2.
Comment 8 Denis Roy CLA 2009-08-30 02:05:47 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.