Community
Participate
Working Groups
I20051018-0932 + ZRH plugin export from 20051021 - The sort members action unnecessarily shows a dialog prompting whether to sort fields as well or not. This seems interrupting and more or less useless, as it resembles more a preference, which is set once and left untouched. A better solution could be a MessageDialogWithToggle to attract the users attention to the potentially arising problems when sorting fields and guiding her to the members sort order preference page where she can configure the desired behavior - Invoking sort members on a type with less than 2 members pops up a dialog telling that there were not enough members to sort. This is interrupting and unnecessary as well IMHO.
Benno, what is your take here ?
First: I wrote it exactly like that. Martin changed it. I think he thought that it does not belong to the preferences, but we have to ask him why he changed it. Second: I will look into that. I agree that it is unnecessary, if a user wants to sort one or less members he should be aible to do so...
The problem is that we don't have any other action preferences, and the sort action just is (IMO) one of the least important actions. It would be just to prominent and distracting on the preference page so that I think it's ok to take the pain of an extra click on invocation.
I also find the prompt to confirm annoying, since I sort members very frequently. If the only problem is where to put the preference, wouldn't it be appropriate to appear on the "Members Sort Order" preference page? Since the confirmation dialog already has a link to that preferene page, it seems a perfect fit. I have never noticed the case of one member, but it seems doing nothing and not showing any dialog is fine. Since the member list is correctly sorted after the action is executed (there was no failure), a dialog seems unnecessary. In any case, I don't really care about this one because I would never think of sorting a type with one member ;)
Why not just add a single checkbox "sort fields" and a simple hint about its consequences on the members sort order preference page? I do not see this issue as an action preference, but just an extension to the sort order
I think the warning dialog makes sense as out of box experience, since users might not be aware of the subtle errors that can be caused by sorting initializers. There just needs to be a way to get rid of the prompt once you are aware of the risk. Adding a "remember my decision" checkbox to the dialog would also work.
Martin, we have to discuss this again. The current solution only seems to fulfill the goal of a 'nice' preference page, but OTOH heavily interferes with common usage scenarios such as comment 4. The switch is IMO a preference and not an option, since the user wants to decide this once and for all, and not on a case-by-case basis. Therefore, it belongs to the preference page where all the other preferences affecting the sort order are located. I agree with the solution from comment 5. Another solution would be to just never reorder the dangerous members and not to offer any preference (bug 109562 also didn't request one). If the dialog box really has to stay, then the action would have to be renamed to "Sort Members...".
Many actions show a dialog first. Why is this such a problem here? I would like to add a 'don't ask me again' check box, but again we're missing a preference to undo that. Maybe we shoulod think of introducing that.
added a 'do not show again' check box > 20051108 All 'do not show again' states can now be cleared on the Java preference page
Verified implementation with a dialog including a "do not show again" checkbox, which can be cleared on the Java preference page. Verified in I20051213-0010.
