Bug 113051 - No classpath marker produced when cycle through PDE container
Summary: No classpath marker produced when cycle through PDE container
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-19 04:55 EDT by Philipe Mulet CLA
Modified: 2005-10-28 11:47 EDT (History)
2 users (show)

See Also:


Attachments
Builder + CPInit traces (268.84 KB, text/plain)
2005-10-19 04:59 EDT, Philipe Mulet CLA
no flags Details
Patch against v_617 (5.29 KB, patch)
2005-10-19 09:51 EDT, Jerome Lanneluc CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2005-10-19 04:55:15 EDT
Build id: I20051012-1200

When inducing a classpath cycle through PDE containers, no markers got produced
to complain about the cycle.

0. autobuild off
1. create plugin project AP1 (keep defaults, do not jump to PDE perspective)
2. create plugin project AP2 (keep defaults, do not jump to PDE perspective)
3. create plugin project AP3 (keep defaults, do not jump to PDE perspective)
4. remove JRE entry from AP1 build path (select in explorer, buildpath>remove...)
5. remove JRE entry from AP2 build path (select in explorer, buildpath>remove...)
6. remove JRE entry from AP3 build path (select in explorer, buildpath>remove...)
7. in AP1 dependencies, add AP3 as required plugin
8. in AP2 dependencies, add AP1 as required plugin
9. in AP3 dependencies, add AP2 as required plugin

Severity	Description	Resource	Path	Location	Creation Time	Id
2	The project cannot be built until its prerequisite AP3 is built. Cleaning and
building all projects is recommended	AP1			October 19, 2005 10:46:03 AM	10
2	The project cannot be built until its prerequisite AP1 is built. Cleaning and
building all projects is recommended	AP2			October 19, 2005 10:46:03 AM	11
2	The project cannot be built until its prerequisite AP2 is built. Cleaning and
building all projects is recommended	AP3			October 19, 2005 10:46:03 AM	12

--> observe no buildpath cycle problem in problem view
--> clean has no effect
--> lowered severity for buildpath cycle to warning had no effect

Build order is: AP1, AP2, AP3
Comment 1 Philipe Mulet CLA 2005-10-19 04:59:06 EDT
Created attachment 28430 [details]
Builder + CPInit traces
Comment 2 Philipe Mulet CLA 2005-10-19 05:03:59 EDT
Note: when creating plain Java projects, and manually setting circular
dependencies, cycle markers are detected.
Comment 3 Jerome Lanneluc CLA 2005-10-19 09:51:49 EDT
Created attachment 28440 [details]
Patch against v_617

Tim, can you please try this patch and let me know if this fixes your problem ?

If you prefer a binary patch, let me know as well and I'll post a jdt.core
update.
Comment 4 Tim Ellison CLA 2005-10-19 17:07:46 EDT
Assuming I applied your patch correctly (loaded org.eclipse.jdt.core from CVS
HEAD, and imported dependents from workspace, then applied patch and ran as
Eclipse application)...

This had no effect on the problem I see.  The cycle warning markers are shown,
however, on one launch I get a 'project cannot be built until prereq built'
error, and then when launching again got an 'Access restriction' error.
Comment 5 Philipe Mulet CLA 2005-10-20 02:55:54 EDT
It wasn't supposed to address the entire problem, but at least reveal the cycle
marker which were hidden in the past. Still there seem to be some remaining
issue, as this should build in the end.
Comment 6 Jerome Lanneluc CLA 2005-10-20 06:20:30 EDT
Tim, can you please describe your problem in details in a separate bug ?
The particular problem described by Philippe in comment 0 is now fixed.

(Applyied attached patch and added regression test
ClasspathTests#testCycleDetection4())
Comment 7 Olivier Thomann CLA 2005-10-28 11:47:54 EDT
Cycling markers are now properly reported:
A cycle was detected in the build path of project: AP1	AP1
A cycle was detected in the build path of project: AP2	AP2
A cycle was detected in the build path of project: AP3	AP3

Verified for 3.2 M3 using build I20051025-0800+JDT/Core v_618a