Bug 112521 - Diagram Assistants should not appear if editor is not active
Summary: Diagram Assistants should not appear if editor is not active
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P3 normal
Target Milestone: ---   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-10-13 13:50 EDT by Cherie Revells CLA
Modified: 2006-09-10 23:54 EDT (History)
0 users

See Also:

Attachments
Patch (5.83 KB, patch)
2005-10-14 11:18 EDT, Cherie Revells CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2005-10-13 13:50:22 EDT 
If a user is working in multiple views, such as the properties view and 
outline, each time the mouse moves over the diagram editor en route to another 
view, the diagram assistants (actionbar and connector handles) pop up.

To reduce visual clutter, enable the diagram assistants on the diagram editor 
only if the diagram editor is active (i.e. it is blue).
Comment 1 Cherie Revells CLA 2005-10-14 11:18:54 EDT 
Created attachment 28292 [details]
Patch

Contributed by: Cherie Mahoney
Comment 2 Cherie Revells CLA 2005-10-14 11:21:16 EDT 
See attached patch.

Purpose: 
Bugzilla 112521 Diagram Assistants should not appear if editor is not active
- Created method DiagramAssistantEditPolicy.shouldShowDiagramAssistant which 
checks the conditions that must be met before showing the diagram assistant.
- I moved condition checking spread throughout ActionBarEditPolicy and 
ConnectorHandleEditPolicy to this new method.
- I created a new condition where the diagram assistant will not appear if the 
currently active part is not the diagram.
- Created a new JUnit: 
org.eclipse.gmf.tests.runtime.diagram.ui.logic.DiagramAssistantTests.testShouldS
howDiagramAssistant

Activities: 
Bugzilla 112521 gmf_head sshaw 051013 Diagram Assistants should not appear if 
editor is not active

Code Reviewed by: 
Steve 

How tested: 
Adhoc testing with connector handles and actionbars including 
- using spacebar to trigger actionbar & connector handles
- verify connector handle and actionbar preference still works

JUnit Tests:   
Launching org.eclipse.gmf.tests.runtime.diagram.ui

OK, Runs:	64, Fails:	0, Errors:	0, 
org.eclipse.gmf.tests.runtime.diagram.ui, Time:	83.718
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug