Comment 1 Anthony Hunter 2005-11-02 14:25:56 EST

We need to figure out a way to fix this.

Comment 2 Wayne 2005-11-07 14:18:30 EST

Created attachment 29462 [details]
Binary DLLs

Binary DLLs.  Please unzip into an "os" folder under
org.eclipse.gmf.runtime.common.ui.printing.win32 and add to source control.

So the result should be
org.eclipse.gmf.runtime.common.ui.printing.win32\os\win32\x86\LANGUAGE_CODE\DiagramPrint.dll


For now they are all the EN version.  They will have to be localized.  This is
to prevent confusion with prior version localized DLLs.

Comment 3 Wayne 2005-11-07 14:19:30 EST

Created attachment 29463 [details]
Update headers for the DiagramPrint project

Comment 4 Anthony Hunter 2005-11-07 16:36:02 EST

Committed the DLL files.

Did not commit the header updates to the contrib folder, we need to move the
folder somewhere else first (i.e. we cannot patch the source for the original
contribution).

Comment 5 Wayne 2005-11-15 11:26:06 EST

Still an issue when trying to print with the deployed jar.  Can't load dll from 
inside the jar.

Comment 6 Wayne 2005-11-17 11:55:10 EST

Created attachment 30152 [details]
Patch for org.eclipse.gmf.runtime.common.ui.printing.PrintHelper in common.ui.printing.win32

Fixes the static block to work with jars.

Comment 7 Wayne 2005-11-17 11:56:40 EST

Created attachment 30153 [details]
New DLLs that go in the root of org.eclipse.gmf.runtime.common.ui.printing.win32

Please delete the "os" folder completely.  Those DLLs are now obsolete.

Comment 8 Wayne 2005-11-17 11:57:40 EST

Created attachment 30154 [details]
New DLLs that go in the root of org.eclipse.gmf.runtime.common.ui.printing.win32

Please delete the "os" folder completely.  Those DLLs are now obsolete. 
(Resubmitting as binary without "patch" checkbox)

Comment 9 Wayne 2005-11-17 11:59:20 EST

Created attachment 30155 [details]
New dsp files for DiagramPrint DLL project

Updated to reflect the correct DLL naming convention.

Comment 10 Wayne 2005-11-17 11:59:49 EST

Created attachment 30156 [details]
New dsp files for DiagramPrint DLL project

Updated to reflect the correct DLL naming convention (resubmitted as binary
without the patch checkbox).

Comment 11 Wayne 2005-11-17 13:26:54 EST

Created attachment 30160 [details]
New dsp files for DiagramPrint DLL project

Updated to reflect the correct DLL naming convention (resubmitted as binary
without the patch checkbox).

Comment 12 Anthony Hunter 2005-11-17 16:49:04 EST

Committed the latest patches.

Comment 13 Anthony Hunter 2005-11-21 14:36:01 EST

patches committed, so changing resolution to FIXED

Comment 14 Wayne 2005-12-08 14:28:01 EST

The source code for the C++ DLL for printing diagrams under Windows is currently still under org.eclipse.gmf/contributions/ibm-gmf-runtime/cpp-source/DiagramPrint 

It wasn't moved along with the rest of the projects. 

I propose to put the DiagramPrint DLL in org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.common.ui.printing.win32/DiagramPrint.  The next attachment contains a zip for the contents of this directory.

Comment 15 Wayne 2005-12-08 14:30:52 EST

Created attachment 31405 [details]
Patched DiagramPrint source

Contains all original code and above patches.  When committing, please unzip into the destination directory, org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.common.ui.printing.win32/DiagramPrint

Comment 16 Anthony Hunter 2006-01-10 10:30:09 EST

Delivered in M4, will commit the DLL source next week

Comment 17 Richard Gronback 2008-08-13 13:06:23 EDT

[target cleanup] 1.0 M4 was the original target milestone for this bug

Comment 18 Eclipse Webmaster 2010-07-19 21:55:14 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime Common was the original product and component for this bug