Bug 111907 - Palette Service refactoring: allow definition of a palette drawer with-out forcing a contribution
Summary: Palette Service refactoring: allow definition of a palette drawer with-out fo...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P1 enhancement
Target Milestone: 1.0   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2005-10-07 10:44 EDT by Steven R. Shaw CLA
Modified: 2008-08-13 13:07 EDT (History)
2 users (show)

See Also:

Attachments
Describes how client will use it. (26.00 KB, application/msword)
2006-03-29 09:26 EST, Cherie Revells CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steven R. Shaw CLA 2005-10-07 10:44:01 EDT 
- This is necessary for plug-ins that wish to define a default drawer that 
clients may wish to utilize of not.  i.e. Geoshapes 
- Ability to open the geoshapes palette drawer by default is dependent on this.
Comment 1 Chris Aniszczyk CLA 2005-11-22 18:10:10 EST 
Is this related to two different semantic models contributing to an editor their palettes. I have this use case where I need two different semantic models (with appropriate gmf runtime providers, etc...) to share an editor and sprinkle them with some OCL rules to govern possible cross semantic model relationships.
Comment 2 Cherie Revells CLA 2005-11-23 14:10:25 EST 
It is already possible to create multiple palettes, so I don't think the last point is an issue.
Comment 3 Steven R. Shaw CLA 2005-12-21 10:42:44 EST 
Moving to M5
Comment 4 Steven R. Shaw CLA 2006-02-22 09:23:45 EST 
Moving to M6.  Not enough time left in M5 to address this.
Comment 5 Cherie Revells CLA 2006-03-29 09:26:31 EST 
Created attachment 37198 [details]
Describes how client will use it.
Comment 6 Cherie Revells CLA 2006-03-29 17:05:19 EST 
Purpose: 
Bugzilla#111907 Support Separation of Palette Definition and Contribution
- Updated the palette schema to support definition of a palette entry only and contribution of a palette entry that was predefined, as well as removing an existing palette entry
- Changed the public API in IPaletteProvider from: contributeToPalette(IEditorPart editor, Object content, PaletteRoot root)
to:  contributeToPalette(IEditorPart editor, Object content, PaletteRoot root, Map predefinedEntries)
The Taipan example needed to be updated, but I don't expect any other clients implement IPaletteProvider directly.
- Updated the DefaultPaletteProvider to conform to the new API and support the new functionality.
- Added section "Separating the Definition and Contribution of a Palette Entry" to the "Configuring and Extending 
the Diagram Palette" tutorial in the GMF SDK.
- Added XML in the org.eclipse.gmf.examples.runtime.diagram.geoshapes plugin to expand the geoshapes drawer by default.
- Added JUnit: PaletteServiceTests.testPredefineAndContributeEntries.

Activities: 
Bugzilla#111907 gmf_head cmahoney 060329 Support Separation of Palette Definition and Contribution

Code Reviewed by:
Steve

How tested: 
- Verified Geoshapes palette is expanded by default on Geoshapes diagram only.

JUnit Tests:  
diagram.ui tests -- all passed
Comment 7 Richard Gronback CLA 2008-08-13 13:07:15 EDT 
[target cleanup] 1.0 M6 was the original target milestone for this bug
Comment 8 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug